iipyper example comments, notepredictor example synth volume

Author: victor-shepardson

examples/iipyper/iipyper-tutorial.py

@@ -2,9 +2,6 @@
 
 from iipyper import OSC, MIDI, repeat, run
 
-# TODO: MIDI
-# TODO: loops are broken, why?
-
 def main(osc_host='127.0.0.1', osc_port=9999, loop_time=1, loop_msg='hello'):
     # loop API:
     # use the @repeat decorator to define functions which run every n seconds
@@ -63,7 +60,7 @@ def keyword_example(address, arg1=0, arg2=1, arg3=99):
         print(address, arg1, arg2, arg3)
         # no return value: does not send OSC back
 
-    # can also give the route explictly to the decorator,
+    # can also give the route explicitly to the decorator,
     # supporting wildcards
     @osc.args('/math/*')
     def _(address, a, b):
@@ -74,7 +71,7 @@ def _(address, a, b):
         if op=='mul':
             return address, a * b
 
-    # OSC clients can be created explcitly and given names:
+    # OSC clients can be created explicitly and given names:
     osc.create_client('supercollider', port=57120) # uses same host as server
     # but clients will also be created automatically when possible
 
@@ -91,9 +88,8 @@ def _(address, a, b):
     osc('supercollider2', '/other_send_test', 3)
 
 # it may be possible to have async/threaded option for both OSC and MIDI?
-# MIDI is threaded and OSC is async
-# but MIDI could be enqueued and handled in the loop,
-# OSC could launch the threading server?
+# MIDI handlers are threaded in mido and OSC handlers as async in pythonosc.
+# currently MIDI is enqueued and handled async.
 
 if __name__=='__main__':
     run(main)

examples/notepredictor/autopitch.scd

@@ -72,7 +72,7 @@ s.waitForBoot{
 (
 SynthDef(\pluck, {
     var vel = \vel.kr;
-    var signal = Saw.ar(\freq.kr(20), 3e-2) * EnvGate.new(1);
+    var signal = Saw.ar(\freq.kr(20), 0.2) * EnvGate.new(1);
     var fr = 2.pow(Decay.ar(Impulse.ar(0), 3)*6*vel+8);
     signal = BLowPass.ar(signal, fr)*vel;
     Out.ar([0,1], signal);

examples/notepredictor/linnstrument-display.scd

@@ -41,7 +41,7 @@ s.waitForBoot{
     };
     SynthDef(\pluck, {
         var vel = \vel.kr;
-        var signal = Saw.ar(\freq.kr(20), 3e-2) * EnvGate.new(1);
+        var signal = Saw.ar(\freq.kr(20), 0.2) * EnvGate.new(1);
         var fr = 2.pow(Decay.ar(Impulse.ar(0), 3)*6*vel+8);
         signal = BLowPass.ar(signal, fr)*vel;
         Out.ar([0,1], signal);

notepredictor/notepredictor/model.py

@@ -425,7 +425,7 @@ def predict(self,
                 pred_pitch = [x.item() for x in pred_pitch]
                 pred_time = [x.item() for x in pred_time]
                 pred_vel = [x.item() for x in pred_vel]
-                print(pred_time, pred_pitch, pred_vel)
+                # print(pred_time, pred_pitch, pred_vel)
             else:
                 # return single predictions
                 pred_pitch = pred_pitch.item()