Fix body contour panic when looking up (#439)

Aemulation · web-flow · commit 6eb893745a9f · 2025-01-28T23:02:35.000+01:00
diff --git a/yggdrasil/src/vision/body_contour/mod.rs b/yggdrasil/src/vision/body_contour/mod.rs
@@ -147,12 +147,6 @@ impl BodyContour {
     }
 
     fn is_part_of_chest(chest_points: &ChestPoints, image_coordinate: Point2<f32>) -> bool {
-        if image_coordinate.x <= chest_points.first().unwrap().x
-            || image_coordinate.x >= chest_points.last().unwrap().x
-        {
-            return false;
-        }
-
         for (left_point, right_point) in chest_points.iter().zip(chest_points.iter().skip(1)) {
             if image_coordinate.x < right_point.x {
                 let a = (right_point.y - left_point.y) / (right_point.x - left_point.x);
@@ -161,7 +155,7 @@ impl BodyContour {
             }
         }
 
-        unreachable!();
+        false
     }
 
     // # TODO: This might be too simple for a body part that's not static.

Original file line number	Diff line number	Diff line change
`@@ -147,12 +147,6 @@ impl BodyContour {`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`fn is_part_of_chest(chest_points: &ChestPoints, image_coordinate: Point2<f32>) -> bool {`
`150`		`- if image_coordinate.x <= chest_points.first().unwrap().x`
`151`		`- \|\| image_coordinate.x >= chest_points.last().unwrap().x`
`152`		`- {`
`153`		`- return false;`
`154`		`- }`
`155`		`-`
`156`	`150`	`for (left_point, right_point) in chest_points.iter().zip(chest_points.iter().skip(1)) {`
`157`	`151`	`if image_coordinate.x < right_point.x {`
`158`	`152`	`let a = (right_point.y - left_point.y) / (right_point.x - left_point.x);`
`@@ -161,7 +155,7 @@ impl BodyContour {`
`161`	`155`	`}`
`162`	`156`	`}`
`163`	`157`
`164`		`- unreachable!();`
	`158`	`+ false`
`165`	`159`	`}`
`166`	`160`
`167`	`161`	`// # TODO: This might be too simple for a body part that's not static.`