Merge branch 'master' into flaky-tests-fix-2

Author: franco-zalamena-iterable

CHANGELOG.md

@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
+### Fixed
+- Fixed `ConcurrentModificationException` crash during device token registration caused by concurrent access to `deviceAttributes`.
+- Fixed possible `NoSuchMethodException` crash on Android 5-10 caused by using `Map.of()` which is unavailable on those versions
 
 ## [3.7.0]
 - Replaced the deprecated `AsyncTask`-based push notification handling with `WorkManager` for improved reliability and compatibility with modern Android versions. No action is required.

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

@@ -17,10 +17,11 @@
 import org.json.JSONException;
 import org.json.JSONObject;
 
-import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.Objects;
 import java.util.UUID;
+import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * Created by David Truong dt@iterable.com
@@ -55,7 +56,7 @@ public class IterableApi {
     private @Nullable IterableEmbeddedManager embeddedManager;
     private String inboxSessionId;
     private IterableAuthManager authManager;
-    private HashMap<String, String> deviceAttributes = new HashMap<>();
+    private ConcurrentHashMap<String, String> deviceAttributes = new ConcurrentHashMap<>();
     private IterableKeychain keychain;
 
 
@@ -159,7 +160,7 @@ void setAttributionInfo(IterableAttributionInfo attributionInfo) {
         );
     }
 
-    HashMap getDeviceAttributes() {
+    Map<String, String> getDeviceAttributes() {
         return deviceAttributes;
     }
 
@@ -695,7 +696,7 @@ void setAuthToken(String authToken, boolean bypassAuth) {
         }
     }
 
-    protected void registerDeviceToken(final @Nullable String email, final @Nullable String userId, final @Nullable String authToken, final @NonNull String applicationName, final @NonNull String deviceToken, final HashMap<String, String> deviceAttributes) {
+    protected void registerDeviceToken(final @Nullable String email, final @Nullable String userId, final @Nullable String authToken, final @NonNull String applicationName, final @NonNull String deviceToken, final Map<String, String> deviceAttributes) {
         if (deviceToken != null) {
             if (!checkSDKInitialization() && _userIdUnknown == null) {
                 if (sharedInstance.config.enableUnknownUserActivation) {
@@ -740,7 +741,7 @@ protected void disableToken(@Nullable String email, @Nullable String userId, @Nu
      * @param deviceToken
      * @param dataFields
      */
-    protected void registerDeviceToken(@Nullable String email, @Nullable String userId, @Nullable String authToken, @NonNull String applicationName, @NonNull String deviceToken, @Nullable JSONObject dataFields, HashMap<String, String> deviceAttributes) {
+    protected void registerDeviceToken(@Nullable String email, @Nullable String userId, @Nullable String authToken, @NonNull String applicationName, @NonNull String deviceToken, @Nullable JSONObject dataFields, Map<String, String> deviceAttributes) {
         if (!checkSDKInitialization()) {
             return;
         }
@@ -1245,10 +1246,18 @@ public Bundle getPayloadData() {
     }
 
     public void setDeviceAttribute(String key, String value) {
+        if (key == null || value == null) {
+            IterableLogger.e(TAG, "setDeviceAttribute: key and value must not be null");
+            return;
+        }
         deviceAttributes.put(key, value);
     }
 
     public void removeDeviceAttribute(String key) {
+        if (key == null) {
+            IterableLogger.e(TAG, "removeDeviceAttribute: key must not be null");
+            return;
+        }
         deviceAttributes.remove(key);
     }
 //endregion

iterableapi/src/main/java/com/iterable/iterableapi/IterableApiClient.java

@@ -14,8 +14,8 @@
 import org.json.JSONObject;
 
 import java.util.Arrays;
-import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 class IterableApiClient {
     private static final String TAG = "IterableApiClient";
@@ -623,7 +623,7 @@ protected void disableToken(@Nullable String email, @Nullable String userId, @Nu
         }
     }
 
-    protected void registerDeviceToken(@Nullable String email, @Nullable String userId, @Nullable String authToken, @NonNull String applicationName, @NonNull String deviceToken, @Nullable JSONObject dataFields, HashMap<String, String> deviceAttributes, @Nullable final IterableHelper.SuccessHandler successHandler, @Nullable final IterableHelper.FailureHandler failureHandler) {
+    protected void registerDeviceToken(@Nullable String email, @Nullable String userId, @Nullable String authToken, @NonNull String applicationName, @NonNull String deviceToken, @Nullable JSONObject dataFields, Map<String, String> deviceAttributes, @Nullable final IterableHelper.SuccessHandler successHandler, @Nullable final IterableHelper.FailureHandler failureHandler) {
         Context context = authProvider.getContext();
         JSONObject requestJSON = new JSONObject();
         try {
@@ -633,7 +633,7 @@ protected void registerDeviceToken(@Nullable String email, @Nullable String user
                 dataFields = new JSONObject();
             }
 
-            for (HashMap.Entry<String, String> entry : deviceAttributes.entrySet()) {
+            for (Map.Entry<String, String> entry : deviceAttributes.entrySet()) {
                 dataFields.put(entry.getKey(), entry.getValue());
             }
 

iterableapi/src/main/java/com/iterable/iterableapi/IterableHelper.java

@@ -4,10 +4,9 @@
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
+import org.json.JSONException;
 import org.json.JSONObject;
 
-import java.util.Map;
-
 /**
  * Created by David Truong dt@iterable.com
  */
@@ -38,7 +37,17 @@ public interface SuccessAuthHandler {
 }
 
 class IterableResponse {
-    static final JSONObject setEmailLocalSuccessResponse = new JSONObject(Map.of("message", "setEmail was completed locally."));
-
-    static final JSONObject setReadLocalSuccessResponse = new JSONObject(Map.of("message", "setRead was completed locally."));
+    static final JSONObject setEmailLocalSuccessResponse;
+    static final JSONObject setReadLocalSuccessResponse;
+
+    static {
+        JSONObject emailResponse = new JSONObject();
+        JSONObject readResponse = new JSONObject();
+        try {
+            emailResponse.put("message", "setEmail was completed locally.");
+            readResponse.put("message", "setRead was completed locally.");
+        } catch (JSONException ignored) {}
+        setEmailLocalSuccessResponse = emailResponse;
+        setReadLocalSuccessResponse = readResponse;
+    }
 }