Merged PR 1768176: [Index Policies] Add a few more metadata lines in index policy logging

### Does this PR have any customer impact?
No

### Type (Feature, Refactoring, Bugfix, DevOps, Testing, Perf, etc)
Logging

### Does it involve schema level changes? (Table, Column, Index, UDF, etc level changes)
No
### Are you introducing any new config? If yes, do you have tests with and without them being set?

### ChangeLog (Refer [Template](../oss/CHANGELOG.md))

### Description
1) Track whether or not the index is TTL
2) Track numPaths different from numKeys (needed for composite)
3) Track whether it's a composite index or not

Also add a check that checks that the PG index is valid as part of updating the stats before marking the index as valid in the documentdb Catalog

----
#### AI description  (iteration 1)
#### PR Classification
Enhancement: The pull request updates index policy logging by adding new metadata fields and refining index property validations.

#### PR Summary
This pull request enriches index policy logging by incorporating new utility functions and metadata details to better capture index characteristics and ensure index integrity.
- **`src/metadata/index.c`**: Added `IndexSpecIsWildcardIndex` and `IndexSpecIsOrderedIndex` functions to determine index types.
- **`src/utils/index_policies_utils.c`**: Enhanced `BuildIndexMetricLog` by logging additional fields such as `numPaths`, `hasTtl`, `hasPfe`, and computing the wildcard and ordered index flags.
- **`include/metadata/index.h`**: Introduced new inline functions for boolean conversion with default behaviors.
- **Commands modules** (`create_indexes.c`, `coll_mod.c`, and `drop_indexes.c`): Updated validations (e.g., checking index liveliness) and adjusted boolean handling to align with the new metadata scheme.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->

Author: visridha

pg_documentdb/include/metadata/index.h

@@ -240,6 +240,8 @@ List * CollectionIdGetIndexNames(uint64 collectionId, bool excludeIdIndex, bool
 								 inProgressOnly);
 int CollectionIdGetIndexCount(uint64 collectionId);
 int CollectionIdsGetIndexCount(ArrayType *collectionIdsArray);
+bool IndexSpecIsWildcardIndex(const IndexSpec *indexSpec);
+bool IndexSpecIsOrderedIndex(const IndexSpec *indexSpec);
 
 
 /* modify/write index metadata */
@@ -320,11 +322,18 @@ const char * GetIndexTypeFromKeyDocument(pgbson *keyDocument);
 /* Static utilities */
 
 static inline bool
-GetBoolFromBoolIndexOption(BoolIndexOption option)
+GetBoolFromBoolIndexOptionDefaultTrue(BoolIndexOption option)
 {
 	return option == BoolIndexOption_Undefined ||
 		   option == BoolIndexOption_False ? false : true;
 }
 
 
+static inline bool
+GetBoolFromBoolIndexOptionDefaultFalse(BoolIndexOption option)
+{
+	return option == BoolIndexOption_True;
+}
+
+
 #endif

pg_documentdb/src/commands/coll_mod.c

@@ -574,9 +574,9 @@ ModifyIndexSpecsInCollection(const MongoCollection *collection,
 	if ((*specFlags & HAS_INDEX_OPTION_HIDDEN) == HAS_INDEX_OPTION_HIDDEN)
 	{
 		PgbsonWriterAppendBool(writer, "hidden_old",
-							   10, GetBoolFromBoolIndexOption(oldHidden));
+							   10, GetBoolFromBoolIndexOptionDefaultTrue(oldHidden));
 		PgbsonWriterAppendBool(writer, "hidden_new",
-							   10, GetBoolFromBoolIndexOption(newHidden));
+							   10, GetBoolFromBoolIndexOptionDefaultTrue(newHidden));
 	}
 
 	if ((*specFlags & HAS_INDEX_OPTION_EXPIRE_AFTER_SECONDS) ==

pg_documentdb/src/commands/create_indexes.c

@@ -6372,10 +6372,21 @@ UpdateIndexStatsForPostgresIndex(uint64 collectionId, List *indexIdList)
 		List *columnNumbers = NIL;
 		if (indexOid != InvalidOid)
 		{
+			bool indexIsLive = false;
 			Relation indexRel = index_open(indexOid, AccessShareLock);
+			indexIsLive = indexRel->rd_index->indislive;
 			IndexInfo *indexInfo = BuildIndexInfo(indexRel);
 			RelationClose(indexRel);
 
+			/* Use this chance to validate that the index is live*/
+			if (!indexIsLive)
+			{
+				ereport(ERROR, (errcode(ERRCODE_DOCUMENTDB_INTERNALERROR),
+								errmsg(
+									"Index %s is not live, but index build was marked as completed",
+									indexName)));
+			}
+
 			/* Only do this for RUM style indexes. Vector and Geospatial indexes do need statistics. */
 			if (!IsBsonRegularIndexAm(indexInfo->ii_Am))
 			{

pg_documentdb/src/commands/drop_indexes.c

@@ -697,7 +697,7 @@ DropPostgresIndexWithSuffix(uint64 collectionId, IndexDetails *index, bool concu
 	Assert(suffix != NULL);
 
 	StringInfo cmdStr = makeStringInfo();
-	bool isUnique = GetBoolFromBoolIndexOption(index->indexSpec.indexUnique);
+	bool isUnique = GetBoolFromBoolIndexOptionDefaultFalse(index->indexSpec.indexUnique);
 	if (isUnique || (strncmp(index->indexSpec.indexName,
 							 ID_INDEX_NAME, strlen(ID_INDEX_NAME)) == 0))
 	{

pg_documentdb/src/metadata/index.c

@@ -2107,6 +2107,65 @@ GetMongoIndexKind(char *indexKindName, bool *isSupported)
 }
 
 
+bool
+IndexSpecIsWildcardIndex(const IndexSpec *indexSpec)
+{
+	if (indexSpec->indexWPDocument != NULL)
+	{
+		return true;
+	}
+
+	if (indexSpec->indexKeyDocument == NULL)
+	{
+		return false;
+	}
+
+	bson_iter_t keyDocument;
+	PgbsonInitIterator(indexSpec->indexKeyDocument, &keyDocument);
+	while (bson_iter_next(&keyDocument))
+	{
+		const StringView keyView = bson_iter_key_string_view(&keyDocument);
+		if (StringViewEndsWithString(&keyView, "$**"))
+		{
+			return true;
+		}
+	}
+
+	return false;
+}
+
+
+inline static bool
+IsOptionsKeyOrderedIndex(const char *key)
+{
+	return strcmp(key, "enableCompositeTerm") == 0 ||
+		   strcmp(key, "enableOrderedIndex") == 0;
+}
+
+
+bool
+IndexSpecIsOrderedIndex(const IndexSpec *indexSpec)
+{
+	if (indexSpec->indexOptions == NULL)
+	{
+		return false;
+	}
+
+	bson_iter_t iter;
+	PgbsonInitIterator(indexSpec->indexOptions, &iter);
+	while (bson_iter_next(&iter))
+	{
+		const char *key = bson_iter_key(&iter);
+		if (IsOptionsKeyOrderedIndex(key))
+		{
+			return BsonValueAsBool(bson_iter_value(&iter));
+		}
+	}
+
+	return false;
+}
+
+
 /*
  * Serializes the IndexKey to a GetIndexes friendly manner.
  * Returns any additional Text indexes that were captured from processing
@@ -2413,8 +2472,7 @@ static bool
 AreIndexOptionsStillEquivalent(const char *path, const bson_value_t *left,
 							   const bson_value_t *right)
 {
-	if (strcmp(path, "enableCompositeTerm") == 0 ||
-		strcmp(path, "enableOrderedIndex") == 0)
+	if (IsOptionsKeyOrderedIndex(path))
 	{
 		if (left == NULL && right == NULL)
 		{