Skip to content

Commit 85db7d5

Browse files
author
jfusco
committed
Fixing bug #1 where user could not move cursor right after non fuzzy search. Updating README
1 parent 0ad4bc9 commit 85db7d5

11 files changed

Lines changed: 12 additions & 16 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
> WAI-ARIA compliant React autocomplete component
1212
13-
### Demo
13+
## Demo ##
1414
https://jfusco.github.io/react-predictive-input
1515

1616
## Getting Started ##
@@ -52,7 +52,7 @@ class Application extends Component{
5252
id="fruit"
5353
placeholder="Search a type of fruit"
5454
data={this.props.fruit}
55-
onSelected={::this.onItemSelected)} />
55+
onSelected={this.onItemSelected.bind(this)} />
5656
</div>
5757
);
5858
}

dist/react-autocomplete.js

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/react-autocomplete.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/bundle.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ return /******/ (function(modules) { // webpackBootstrap
266266
_react2.default.createElement(
267267
'pre',
268268
null,
269-
'<Autocomplete\n\tid="fruit"\n\tonSelected={::this.onSelected}\n\tdata={this.props.fruit} />\n\nvalue: ' + this.state.value
269+
'<Autocomplete\n\tid="fruit"\n\tonSelected={this.onSelected.bind(this)}\n\tdata={this.props.fruit} />\n\nvalue: ' + this.state.value
270270
)
271271
)
272272
);
@@ -21778,8 +21778,6 @@ return /******/ (function(modules) { // webpackBootstrap
2177821778
case Autocomplete.KEYS.right:
2177921779
if (!this.willRenderTypeahead()) return;
2178021780

21781-
e.preventDefault();
21782-
2178321781
this.selectSuggestion(this.state.data[0]);
2178421782
break;
2178521783

docs/coverage/clover.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<coverage generated="1478455409443" clover="3.2.0">
3-
<project timestamp="1478455409443" name="All files">
2+
<coverage generated="1478549392715" clover="3.2.0">
3+
<project timestamp="1478549392715" name="All files">
44
<metrics statements="5" coveredstatements="5" conditionals="8" coveredconditionals="4" methods="3" coveredmethods="2" elements="16" coveredelements="11" complexity="0" loc="5" ncloc="5" packages="1" files="1" classes="1">
55
<file name="Suggestion.js" path="/Users/Rinzler/Projects/Personal/react-predictive-input/src/component/js/Suggestion.js">
66
<metrics statements="5" coveredstatements="5" conditionals="8" coveredconditionals="4" methods="3" coveredmethods="2"/>

docs/coverage/lcov-report/Suggestion.js.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ <h1>
106106
</div><!-- /wrapper -->
107107
<div class='footer quiet pad2 space-top1 center small'>
108108
Code coverage
109-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sun Nov 06 2016 13:03:29 GMT-0500 (EST)
109+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Nov 07 2016 15:09:52 GMT-0500 (EST)
110110
</div>
111111
</div>
112112
<script src="prettify.js"></script>

docs/coverage/lcov-report/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ <h1>
7777
</div><!-- /wrapper -->
7878
<div class='footer quiet pad2 space-top1 center small'>
7979
Code coverage
80-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Sun Nov 06 2016 13:03:29 GMT-0500 (EST)
80+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Mon Nov 07 2016 15:09:52 GMT-0500 (EST)
8181
</div>
8282
</div>
8383
<script src="prettify.js"></script>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-predictive-input",
3-
"version": "1.2.4",
3+
"version": "1.2.5",
44
"description": "WAI-ARIA compliant React autocomplete component",
55
"main": "dist/react-autocomplete.js",
66
"license": "MIT",

src/component/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ class App extends Component {
2727
<Autocomplete
2828
id="fruit"
2929
placeholder="Search for a type of fruit"
30+
fuzzy={false}
31+
caseSensitive={true}
3032
data={this.props.fruit}
3133
onSelected={::this.onItemSelected} />
3234
</div>

src/component/js/Autocomplete.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ class Autocomplete extends Component {
137137
case Autocomplete.KEYS.right:
138138
if (!this.willRenderTypeahead()) return;
139139

140-
e.preventDefault();
141-
142140
this.selectSuggestion(this.state.data[0]);
143141
break;
144142

0 commit comments

Comments
 (0)