Skip to content

Commit 8f0ea02

Browse files
committed
revert quiet mode. functionality has been added as decorator.
1 parent 97d957d commit 8f0ea02

1 file changed

Lines changed: 8 additions & 27 deletions

File tree

jmu_gradescope_utils/jmu_test_case.py

Lines changed: 8 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ def assertScriptOutputEqual(self, filename, string_in, expected,
188188

189189
def assertOutputEqual(self, filename, string_in, expected,
190190
variables=None, args="", msg=None,
191-
processor=None, from_files=False, quiet=False):
191+
processor=None, from_files=False):
192192
"""Assert correct output for the provided Python script.
193193
194194
Args:
@@ -205,9 +205,6 @@ def assertOutputEqual(self, filename, string_in, expected,
205205
to the expected output.
206206
from_files (bool): Interpret string_in and expected as a file names rather
207207
than strings. The files should be stored in the scaffolding folder.
208-
quiet (bool): If true, detailed comparison feedback will be hidden. Only
209-
only the string provided in msg will be displayed.
210-
211208
Raises:
212209
AssertionError: If the expected output doesn't match the actual
213210
output.
@@ -223,15 +220,11 @@ def assertOutputEqual(self, filename, string_in, expected,
223220
with open(utils.full_source_path(expected), 'r') as f:
224221
expected = f.read()
225222

226-
if quiet:
227-
if result["stdout"] != expected:
228-
self.fail(msg)
229-
else:
230-
self.assertEqual(result["stdout"], expected, result["msg"])
223+
self.assertEqual(result["stdout"], expected, result["msg"])
231224

232225
def assertOutputNotEqual(self, filename, string_in, expected,
233226
variables=None, args="", msg=None,
234-
processor=None, from_files=False, quiet=False):
227+
processor=None, from_files=False):
235228
"""Assert script output is NOT equal to the indicated string.
236229
237230
See :meth:`~jmu_gradescope_utils.jmu_test_case._JmuTestCase.assertOutputEqual` for
@@ -247,15 +240,11 @@ def assertOutputNotEqual(self, filename, string_in, expected,
247240
with open(utils.full_source_path(expected), 'r') as f:
248241
expected = f.read()
249242

250-
if quiet:
251-
if result["stdout"] == expected:
252-
self.fail(msg)
253-
else:
254-
self.assertNotEqual(result["stdout"], expected, result["msg"])
243+
self.assertNotEqual(result["stdout"], expected, result["msg"])
255244

256245
def assertInOutput(self, filename, string_in, expected,
257246
variables=None, args="", msg=None,
258-
processor=None, from_files=False, quiet=False):
247+
processor=None, from_files=False):
259248
"""Assert script output contains the indicated string.
260249
261250
See :meth:`~jmu_gradescope_utils.jmu_test_case._JmuTestCase.assertOutputEqual` for
@@ -271,15 +260,11 @@ def assertInOutput(self, filename, string_in, expected,
271260
with open(utils.full_source_path(expected), 'r') as f:
272261
expected = f.read()
273262

274-
if quiet:
275-
if result["stdout"] not in expected:
276-
self.fail(msg)
277-
else:
278-
self.assertIn(expected, result["stdout"], result["msg"])
263+
self.assertIn(expected, result["stdout"], result["msg"])
279264

280265
def assertNotInOutput(self, filename, string_in, expected,
281266
variables=None, args="", msg=None,
282-
processor=None, from_files=False, quiet=False):
267+
processor=None, from_files=False):
283268
"""Assert script output does not contain the indicated string.
284269
285270
See :meth:`~jmu_gradescope_utils.jmu_test_case._JmuTestCase.assertOutputEqual` for
@@ -295,11 +280,7 @@ def assertNotInOutput(self, filename, string_in, expected,
295280
with open(utils.full_source_path(expected), 'r') as f:
296281
expected = f.read()
297282

298-
if quiet:
299-
if result["stdout"] in expected:
300-
self.fail(msg)
301-
else:
302-
self.assertNotIn(expected, result["stdout"], result["msg"])
283+
self.assertNotIn(expected, result["stdout"], result["msg"])
303284

304285
def assertNoLoops(self, filename, msg=None):
305286
""" Assert that the provided script has no for or while loops.

0 commit comments

Comments
 (0)