Mejora en la validación de datos de usuario para la aprobación de tickets (#264)

Este PR introduce mejoras en el proceso de validación de datos de
usuario para la aprobación de tickets.

Los cambios principales incluyen:
1. Refactorización de la lógica de validación para diferenciar entre
tickets de equipo (hackathon) y otros.
2. Eliminación de la lista hardcodeada de IDs de tickets de hackathon en
producción, reemplazándola por una verificación basada en tags.
3. Actualización de las pruebas para cubrir escenarios de tickets de
equipo y otros.

Author: TextC0de

src/schema/userTickets/helpers.ts

@@ -117,15 +117,6 @@ type ValidateUserDataAndApproveUserTicketsOptions = {
   logger: Logger;
 };
 
-const HACKATHON_TICKETS_IDS_IN_PROD = [
-  // Dia 1
-  "8ab45972-2497-48b0-8714-f678d18bc5a9",
-  // Dia 2
-  "fae5b2cd-e441-4c43-845c-bfa7c59c7af1",
-  // Inauguracion
-  "900b2eab-3166-4e68-ab93-1831df094471",
-];
-
 export const validateUserDataAndApproveUserTickets = async ({
   DB,
   userId,
@@ -180,16 +171,40 @@ export const validateUserDataAndApproveUserTickets = async ({
     },
   });
 
-  const hackathonUserTickets = [];
-  const nonHackathonUserTickets = [];
+  const ticketTemplatesOfUserTicketsByTemplateId = await ticketsFetcher
+    .searchTickets({
+      DB,
+      search: {
+        ticketIds: userTickets.map((ut) => ut.ticketTemplateId),
+      },
+    })
+    .then((tickets) => {
+      return tickets.reduce(
+        (acc, ticket) => {
+          acc[ticket.id] = ticket;
+
+          return acc;
+        },
+        {} as Record<
+          string,
+          Awaited<ReturnType<typeof ticketsFetcher.searchTickets>>[0]
+        >,
+      );
+    });
+
+  const ticketTemplatesForTeams = [];
+  const ticketTemplatesForAnyone = [];
 
   for (let i = 0; i < userTickets.length; i++) {
     const ut = userTickets[i];
 
-    if (HACKATHON_TICKETS_IDS_IN_PROD.includes(ut.ticketTemplateId)) {
-      hackathonUserTickets.push(ut);
+    const ticketTemplate =
+      ticketTemplatesOfUserTicketsByTemplateId[ut.ticketTemplateId];
+
+    if (ticketTemplate.tags.includes("hackathon")) {
+      ticketTemplatesForTeams.push(ticketTemplate);
     } else {
-      nonHackathonUserTickets.push(ut);
+      ticketTemplatesForAnyone.push(ticketTemplate);
     }
   }
 
@@ -207,7 +222,7 @@ export const validateUserDataAndApproveUserTickets = async ({
     errors.push("City is missing");
   }
 
-  if (hackathonUserTickets.length > 0) {
+  if (ticketTemplatesForTeams.length > 0) {
     // If the user has a team, we check some values of userData.
     if (!userData.emergencyPhoneNumber) {
       errors.push("Emergency contact is missing");

src/schema/userTickets/tests/triggerUserTicketApprovalReview/triggerUserTicketApprovalReview.test.ts

@@ -1,6 +1,8 @@
 import { faker } from "@faker-js/faker";
 import { it, describe, assert } from "vitest";
 
+import { TeamStatusEnum } from "~/datasources/db/teams";
+import { UserParticipationStatusEnum } from "~/datasources/db/userTeams";
 import { userTicketsApprovalStatusEnum } from "~/datasources/db/userTickets";
 import {
   executeGraphqlOperationAsUser,
@@ -12,6 +14,8 @@ import {
   insertTicketTemplate,
   insertUser,
   insertUserData,
+  insertTeam,
+  insertUserTeams,
 } from "~/tests/fixtures";
 
 import {
@@ -22,6 +26,7 @@ import {
 
 const prepareTickets = async (
   status: (typeof userTicketsApprovalStatusEnum)[number] = "gifted",
+  isTeamOnly = false,
 ) => {
   const community1 = await insertCommunity();
   const event1 = await insertEvent();
@@ -33,6 +38,7 @@ const prepareTickets = async (
   const user1 = await insertUser();
   const ticketTemplate1 = await insertTicketTemplate({
     eventId: event1.id,
+    tags: isTeamOnly ? ["hackathon"] : [],
   });
   const purchaseOrder = await insertPurchaseOrder();
   const ticket1 = await insertTicket({
@@ -47,13 +53,57 @@ const prepareTickets = async (
 
 describe("triggerUserTicketApprovalReview mutation", () => {
   describe("It should approve tickets", () => {
-    it("If data is complete and ticket is Gifted", async () => {
-      const { event, user } = await prepareTickets("gifted");
+    it("If data is complete for non-team tickets", async () => {
+      const { event, user } = await prepareTickets("gifted", false);
 
       await insertUserData({
         userId: user.id,
         rut: faker.random.alphaNumeric(10),
+        countryOfResidence: "Chile",
+        city: "Santiago",
       });
+
+      const response = await executeGraphqlOperationAsUser<
+        TriggerUserTicketApprovalReviewMutation,
+        TriggerUserTicketApprovalReviewMutationVariables
+      >(
+        {
+          document: TriggerUserTicketApprovalReview,
+          variables: {
+            eventId: event.id,
+            userId: user.id,
+          },
+        },
+        user,
+      );
+
+      assert.equal(response.errors, undefined);
+
+      assert.equal(response.data?.triggerUserTicketApprovalReview.length, 1);
+    });
+
+    it("If data is complete for team tickets", async () => {
+      const { event, user } = await prepareTickets("gifted", true);
+      const team = await insertTeam({
+        eventId: event.id,
+        teamStatus: TeamStatusEnum.accepted,
+      });
+
+      await insertUserTeams({
+        userId: user.id,
+        teamId: team.id,
+        userParticipationStatus: UserParticipationStatusEnum.accepted,
+      });
+
+      await insertUserData({
+        userId: user.id,
+        rut: faker.random.alphaNumeric(10),
+        countryOfResidence: "Chile",
+        city: "Santiago",
+        emergencyPhoneNumber: "123456789",
+        foodAllergies: "None",
+      });
+
       const response = await executeGraphqlOperationAsUser<
         TriggerUserTicketApprovalReviewMutation,
         TriggerUserTicketApprovalReviewMutationVariables
@@ -75,13 +125,16 @@ describe("triggerUserTicketApprovalReview mutation", () => {
   });
 
   describe("It should not approve tickets", () => {
-    it("If ticket is not pending", async () => {
+    it("If ticket is not gifted", async () => {
       const { event, user } = await prepareTickets("cancelled");
 
       await insertUserData({
         userId: user.id,
         rut: faker.random.alphaNumeric(10),
+        countryOfResidence: "Chile",
+        city: "Santiago",
       });
+
       const response = await executeGraphqlOperationAsUser<
         TriggerUserTicketApprovalReviewMutation,
         TriggerUserTicketApprovalReviewMutationVariables
@@ -100,5 +153,108 @@ describe("triggerUserTicketApprovalReview mutation", () => {
 
       assert.equal(response.data?.triggerUserTicketApprovalReview.length, 0);
     });
+
+    it("If data is incomplete for non-team tickets", async () => {
+      const { event, user } = await prepareTickets("gifted", false);
+
+      await insertUserData({
+        userId: user.id,
+        rut: faker.random.alphaNumeric(10),
+        // Missing countryOfResidence and city
+      });
+
+      const response = await executeGraphqlOperationAsUser<
+        TriggerUserTicketApprovalReviewMutation,
+        TriggerUserTicketApprovalReviewMutationVariables
+      >(
+        {
+          document: TriggerUserTicketApprovalReview,
+          variables: {
+            eventId: event.id,
+            userId: user.id,
+          },
+        },
+        user,
+      );
+
+      assert.notEqual(response.errors, undefined);
+    });
+
+    it("If data is incomplete for team tickets", async () => {
+      const { event, user } = await prepareTickets("gifted", true);
+      const team = await insertTeam({
+        eventId: event.id,
+        teamStatus: TeamStatusEnum.accepted,
+      });
+
+      await insertUserTeams({
+        userId: user.id,
+        teamId: team.id,
+        userParticipationStatus: UserParticipationStatusEnum.accepted,
+      });
+
+      await insertUserData({
+        userId: user.id,
+        rut: faker.random.alphaNumeric(10),
+        countryOfResidence: "Chile",
+        city: "Santiago",
+        // Missing emergencyPhoneNumber and foodAllergies
+      });
+
+      const response = await executeGraphqlOperationAsUser<
+        TriggerUserTicketApprovalReviewMutation,
+        TriggerUserTicketApprovalReviewMutationVariables
+      >(
+        {
+          document: TriggerUserTicketApprovalReview,
+          variables: {
+            eventId: event.id,
+            userId: user.id,
+          },
+        },
+        user,
+      );
+
+      assert.notEqual(response.errors, undefined);
+    });
+
+    it("If team is not accepted for team tickets", async () => {
+      const { event, user } = await prepareTickets("gifted", true);
+      const team = await insertTeam({
+        eventId: event.id,
+        teamStatus: TeamStatusEnum.not_accepted,
+      });
+
+      await insertUserTeams({
+        userId: user.id,
+        teamId: team.id,
+        userParticipationStatus: UserParticipationStatusEnum.accepted,
+      });
+
+      await insertUserData({
+        userId: user.id,
+        rut: faker.random.alphaNumeric(10),
+        countryOfResidence: "Chile",
+        city: "Santiago",
+        emergencyPhoneNumber: "123456789",
+        foodAllergies: "None",
+      });
+
+      const response = await executeGraphqlOperationAsUser<
+        TriggerUserTicketApprovalReviewMutation,
+        TriggerUserTicketApprovalReviewMutationVariables
+      >(
+        {
+          document: TriggerUserTicketApprovalReview,
+          variables: {
+            eventId: event.id,
+            userId: user.id,
+          },
+        },
+        user,
+      );
+
+      assert.notEqual(response.errors, undefined);
+    });
   });
 });

src/tests/fixtures/index.ts

@@ -287,9 +287,8 @@ export const insertUserData = async (
 ) => {
   const possibleInput = {
     id: partialInput?.id ?? faker.string.uuid(),
-    city: partialInput?.city ?? faker.address.city(),
-    countryOfResidence:
-      partialInput?.countryOfResidence ?? faker.address.country(),
+    city: partialInput?.city || "",
+    countryOfResidence: partialInput?.countryOfResidence || "",
     worksInOrganization: partialInput?.worksInOrganization ?? false,
     emergencyPhoneNumber: partialInput?.emergencyPhoneNumber,
     foodAllergies: partialInput?.foodAllergies,