Skip to content

Commit 17ee7f4

Browse files
committed
chore: force default to empty
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 1cc6df4 commit 17ee7f4

3 files changed

Lines changed: 17 additions & 17 deletions

File tree

src/Sign/JSignParam.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
*/
88
class JSignParam
99
{
10-
private ?string $pdf = null;
11-
private ?string $certificate = null;
12-
private ?string $password = null;
10+
private string $pdf = '';
11+
private string $certificate = '';
12+
private string $password = '';
1313
private string $pathPdfSigned = '';
1414
private string $JSignParameters = "-a -kst PKCS12";
1515
private bool $isUseJavaInstalled = false;
1616
private string $javaPath = '';
17-
private ?string $tempPath = null;
17+
private string $tempPath = '';
1818
private string $tempName = '';
1919
private bool $isOutputTypeBase64 = false;
2020
private string $jSignPdfJarPath;
@@ -34,7 +34,7 @@ public static function instance(): self
3434
return new self();
3535
}
3636

37-
public function getPdf(): ?string
37+
public function getPdf(): string
3838
{
3939
return $this->pdf;
4040
}
@@ -45,7 +45,7 @@ public function setPdf(?string $pdf): self
4545
return $this;
4646
}
4747

48-
public function getCertificate(): ?string
48+
public function getCertificate(): string
4949
{
5050
return $this->certificate;
5151
}
@@ -56,7 +56,7 @@ public function setCertificate(?string $certificate): self
5656
return $this;
5757
}
5858

59-
public function getPassword(): ?string
59+
public function getPassword(): string
6060
{
6161
return $this->password;
6262
}
@@ -89,7 +89,7 @@ public function setJSignParameters(string $JSignParameters): self
8989
return $this;
9090
}
9191

92-
public function getTempPath(): ?string
92+
public function getTempPath(): string
9393
{
9494
return $this->tempPath;
9595
}

src/Sign/JSignService.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ private function isPasswordCertificateValid(JSignParam $params): bool
167167
*/
168168
private function pkcs12Read(JSignParam $params): array
169169
{
170-
$certificate = (string) $params->getCertificate();
171-
$password = (string) $params->getPassword();
170+
$certificate = $params->getCertificate();
171+
$password = $params->getPassword();
172172
if (openssl_pkcs12_read($certificate, $certInfo, $password)) {
173173
$this->repackCertificateIfPasswordIsUnicode($params, $certInfo['cert'], $certInfo['pkey']);
174174
return $certInfo;

tests/JSignPDFTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -162,31 +162,31 @@ public function testWithWhenResponseIsBase64()
162162
$this->assertEquals(base64_encode('signed file content'), $signedContent);
163163
}
164164

165-
public function testSignWhenCertificateIsNull()
165+
public function testSignWhenCertificateIsEmpty()
166166
{
167167
$this->expectExceptionMessage('Certificate is Empty or Invalid.');
168-
$params = JSignParamBuilder::instance()->withDefault()->setCertificate(null);
168+
$params = JSignParamBuilder::instance()->withDefault()->setCertificate('');
169169
$this->service->sign($params);
170170
}
171171

172-
public function testSignWhenPdfIsNull()
172+
public function testSignWhenPdfIsEmpty()
173173
{
174174
$this->expectExceptionMessage('PDF is Empty or Invalid.');
175-
$params = JSignParamBuilder::instance()->withDefault()->setPdf(null);
175+
$params = JSignParamBuilder::instance()->withDefault()->setPdf('');
176176
$this->service->sign($params);
177177
}
178178

179-
public function testSignWhenPasswordIsNull()
179+
public function testSignWhenPasswordIsEmpty()
180180
{
181181
$this->expectExceptionMessage('Certificate Password is Empty.');
182-
$params = JSignParamBuilder::instance()->withDefault()->setPassword(null);
182+
$params = JSignParamBuilder::instance()->withDefault()->setPassword('');
183183
$this->service->sign($params);
184184
}
185185

186186
public function testSignWhenTempPathIsInvalid()
187187
{
188188
$this->expectExceptionMessage('Temp Path is invalid or has not permission to writable.');
189-
$params = JSignParamBuilder::instance()->withDefault()->setTempPath(null);
189+
$params = JSignParamBuilder::instance()->withDefault()->setTempPath('');
190190
$this->service->sign($params);
191191
}
192192

0 commit comments

Comments
 (0)