feat: use a temp file to didentify the java version

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

src/Runtime/JavaRuntimeService.php

@@ -37,9 +37,7 @@ public function getPath(JSignParam $params): string
                     throw new InvalidArgumentException('The java base dir is not a real directory. Create this directory first: '. $baseDir);
                 }
             }
-            try {
-                self::validateVersion($params);
-            } catch (RuntimeException) {
+            if (!self::validateVersion($params)) {
                 self::downloadAndExtract($downloadUrl, $javaPath);
             }
             $params->setJavaDownloadUrl('');
@@ -52,20 +50,10 @@ public function getPath(JSignParam $params): string
 
     private function validateVersion(JSignParam $params): bool
     {
-        $version = $params->getJavaVersion();
-        if (!$version) {
-            throw new InvalidArgumentException('Java version required');
-        }
         $javaPath = $params->getJavaPath();
-        \exec($javaPath . ' -version 2>&1', $javaVersion, $resultCode);
-        if (count($javaVersion) <= 1) {
-            throw new RuntimeException('Failed to execute Java. Sounds that your operational system is blocking the JVM.');
-        }
-        if ($resultCode !== 0) {
-            throw new RuntimeException('Failure to check Java version.');
-        }
-        $javaVersion = current($javaVersion);
-        return $javaVersion === $version;
+        $baseDir = preg_replace('/\/bin\/java$/', '', $javaPath);
+        $lastVersion = $baseDir . '/.java_version_' . basename($params->getJavaDownloadUrl());
+        return file_exists($lastVersion);
     }
 
     private function downloadAndExtract(string $url, string $baseDir): void
@@ -94,7 +82,10 @@ private function downloadAndExtract(string $url, string $baseDir): void
         $tar->extractTo(directory: $baseDir, overwrite: true);
         @exec('mv ' . escapeshellarg($baseDir . '/'. $rootDirInsideTar) . '/* ' . escapeshellarg($baseDir));
         @exec('rm -rf ' . escapeshellarg($baseDir . '/'. $rootDirInsideTar));
+        $cacheFile = '/.java_version_' . basename($url);
+        @exec('rm ' . escapeshellarg($baseDir) . $cacheFile);
         unlink($baseDir . '/java.tar.gz');
+        touch($baseDir . $cacheFile);
         if (!file_exists($baseDir . '/bin/java')) {
             throw new RuntimeException('Java binary not found at: ' . $baseDir . '/bin/java');
         }

tests/Runtime/JavaRuntimeServiceTest.php

@@ -65,15 +65,6 @@ public function testGetPathWithDownloadUrlAndNotRealDirectory(): void {
         $service->getPath($jsignParam);
     }
 
-    public function testGetPathWithDownloadUrlAndEmptyJavaVersion(): void {
-        $jsignParam = new JSignParam();
-        $service = new JavaRuntimeService();
-        $jsignParam->setJavaVersion('');
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessageMatches('/Java version required/');
-        $service->getPath($jsignParam);
-    }
-
     public function testGetPathWithDownloadUrlWithInvalidUrl(): void {
         vfsStream::setup('download');
         mkdir('vfs://download/bin');
@@ -83,7 +74,6 @@ public function testGetPathWithDownloadUrlWithInvalidUrl(): void {
         $service = new JavaRuntimeService();
         $jsignParam->setJavaPath('vfs://download/bin/java');
         $jsignParam->setJavaDownloadUrl('invalid_url');
-        $jsignParam->setJavaVersion('21.0.0');
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessageMatches('/url.*invalid/');
         $service->getPath($jsignParam);
@@ -98,7 +88,6 @@ public function testGetPathWithDownloadUrlWith4xxError(): void {
         $service = new JavaRuntimeService();
         $jsignParam->setJavaPath('vfs://download/bin/java');
         $jsignParam->setJavaDownloadUrl('https://404.domain');
-        $jsignParam->setJavaVersion('21.0.0');
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessageMatches('/Failure to download/');
         $service->getPath($jsignParam);
@@ -125,7 +114,6 @@ public function testGetPathWithDownloadUrlWithInvalidGzipedFile(): void {
         $url = $server->getServerRoot();
         $jsignParam->setJavaDownloadUrl($url);
 
-        $jsignParam->setJavaVersion('21.0.0');
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessageMatches('/cannot be extracted/');
         $service->getPath($jsignParam);
@@ -153,12 +141,48 @@ public function testGetPathWithDownloadUrlWithInvalidJavaPackage(): void {
         $url = $server->getServerRoot();
         $jsignParam->setJavaDownloadUrl($url);
 
-        $jsignParam->setJavaVersion('21.0.0');
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessageMatches('/Invalid tar content/');
         $service->getPath($jsignParam);
     }
 
+    public function testGetPathWithDownloadUrlWithInvalidVersion(): void {
+        $jsignParam = new JSignParam();
+        $service = new JavaRuntimeService();
+
+        // When the version is invalid, will try to download the package
+        $server = new MockWebServer();
+        $server->start();
+        $server->setResponseOfPath(
+            '/',
+            new Response('invalid response'),
+        );
+        $baseUrl = $server->getServerRoot();
+        $url = $baseUrl . '/OpenJDK21U-jre_x64_linux_hotspot_21.0.8_9.tar.gz';
+        $jsignParam->setJavaDownloadUrl($url);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessageMatches('/cannot be extracted/');
+        $service->getPath($jsignParam);
+    }
+
+    public function testGetPathWithDownloadUrlWithValidVersion(): void {
+        $jsignParam = new JSignParam();
+        $service = new JavaRuntimeService();
+
+        $tarGzFilename = 'OpenJDK21U-jre_x64_linux_hotspot_21.0.8_9.tar.gz';
+        $url = 'https://fake.url/' . $tarGzFilename;
+        $jsignParam->setJavaDownloadUrl($url);
+
+        // When have a file with an expected name, will consider that the
+        // downloaded java version is right
+        touch($this->testTmpDir . '/.java_version_' . $tarGzFilename);
+        $jsignParam->setJavaPath($this->testTmpDir . '/bin/java');
+
+        $javaPath = $service->getPath($jsignParam);
+        $this->assertEquals($jsignParam->getJavaPath(), $javaPath);
+    }
+
     public function testGetPathWithoutJavaFallback(): void {
         mkdir($this->testTmpDir . '/bin', 0755, true);