Merge pull request #20 from JSignPdf/fix/escape-password

Fix/escape password

Author: jeidison

src/Sign/JSignService.php

@@ -111,7 +111,8 @@ private function commandSign(JSignParam $params)
         }
         $this->throwIf(!file_exists($jSignPdf), 'Jar of JSignPDF not found on path: '. $jSignPdf);
 
-        return "$java -jar $jSignPdf $pdf -ksf $certificate -ksp '{$params->getPassword()}' {$params->getJSignParameters()} -d {$params->getPathPdfSigned()} 2>&1";
+        $password = escapeshellarg($params->getPassword());
+        return "$java -jar $jSignPdf $pdf -ksf $certificate -ksp {$password} {$params->getJSignParameters()} -d {$params->getPathPdfSigned()} 2>&1";
     }
 
     private function javaCommand(JSignParam $params)

tests/JSignPDFTest.php

@@ -67,6 +67,19 @@ public function testSignSuccess()
         $this->assertNotNull($fileSigned);
     }
 
+    public function testSignUsingPasswordWithQuote()
+    {
+        if (!class_exists('JSignPDF\JSignPDFBin\JavaCommandService')) {
+            $this->markTestSkipped('Install jsignpdf/jsignpdf-bin');
+        }
+        $params = JSignParamBuilder::instance()->withDefault();
+        $password = "with ' quote";
+        $params->setCertificate($this->getNewCert($password));
+        $params->setPassword($password);
+        $fileSigned = $this->service->sign($params);
+        $this->assertNotNull($fileSigned);
+    }
+
     public function testCertificateExpired()
     {
         if (!class_exists('JSignPDF\JSignPDFBin\JavaCommandService')) {