chore: Performance improvement

Test validate method directly to dont run jsignpdf when we only need to
test the validate method

Signed-off-by: Vitor Mattos <vitor@php.rio>

Author: vitormattos

src/Sign/JSignService.php

@@ -22,7 +22,6 @@ public function sign(JSignParam $params)
     {
         try {
             $this->validation($params);
-            $this->repackCertificateIfPasswordIsUnicode($params);
 
             $commandSign = $this->commandSign($params);
             \exec($commandSign, $output);
@@ -57,12 +56,11 @@ public function sign(JSignParam $params)
      * unicode chars. As workaround, I changed the password certificate in
      * memory.
      */
-    private function repackCertificateIfPasswordIsUnicode(JSignParam $params)
+    private function repackCertificateIfPasswordIsUnicode(JSignParam $params, $cert, $pkey)
     {
         if (!mb_detect_encoding($params->getPassword(), 'ASCII', true)) {
             $password = md5(microtime());
-            $certInfo = $this->pkcs12Read($params);
-            $newCert = $this->exportToPkcs12($certInfo['cert'], $certInfo['pkey'], $password);
+            $newCert = $this->exportToPkcs12($cert, $pkey, $password);
             $params->setPassword($password);
             $params->setCertificate($newCert);
         }
@@ -86,7 +84,7 @@ public function getVersion(JSignParam $params)
         return explode('version ', $lastRow)[1];
     }
 
-    private function validation(JSignParam $params)
+    public function validation(JSignParam $params)
     {
         $this->throwIf(empty($params->getTempPath()) || !is_writable($params->getTempPath()), 'Temp Path is invalid or has not permission to writable.');
         $this->throwIf(empty($params->getPdf()), 'PDF is Empty or Invalid.');
@@ -175,6 +173,7 @@ private function pkcs12Read(JSignParam $params)
         $certificate = $params->getCertificate();
         $password = $params->getPassword();
         if (openssl_pkcs12_read($certificate, $certInfo, $password)) {
+            $this->repackCertificateIfPasswordIsUnicode($params, $certInfo['cert'], $certInfo['pkey']);
             return $certInfo;
         }
         $msg = openssl_error_string();
@@ -200,6 +199,7 @@ private function pkcs12Read(JSignParam $params)
             unlink($tempEncriptedRepacked);
             unlink($tempDecrypted);
             openssl_pkcs12_read($certificateRepacked, $certInfo, $password);
+            $this->repackCertificateIfPasswordIsUnicode($params, $certInfo['cert'], $certInfo['pkey']);
             return $certInfo;
         }
         return [];

tests/JSignPDFTest.php

@@ -57,6 +57,7 @@ public function testSignSuccess()
 
     /**
      * @dataProvider providerSignUsingDifferentPasswords
+     * @doesNotPerformAssertions
      */
     public function testSignUsingDifferentPasswords(string $password)
     {
@@ -66,8 +67,7 @@ public function testSignUsingDifferentPasswords(string $password)
         $params = JSignParamBuilder::instance()->withDefault();
         $params->setCertificate($this->getNewCert($password));
         $params->setPassword($password);
-        $fileSigned = $this->service->sign($params);
-        $this->assertNotNull($fileSigned);
+        $this->service->validation($params);
     }
 
     public function providerSignUsingDifferentPasswords()