Commit d5b8f13
committed
fix(embedding): add LM Studio support to with_auto_from_env() and expose feature flag
This fixes the false alarm error where embeddings were working correctly
but the system still logged "Falling back to random hash-based embeddings".
Root cause: with_auto_from_env() only initialized Jina and Ollama providers,
missing LM Studio entirely. This caused the error to appear when
EmbeddingGenerator::with_auto_from_env() was called (e.g., in indexer.rs:1678
for symbol resolution), even though the main indexing used with_config() which
properly initialized LM Studio.
Changes:
1. Added LM Studio initialization to with_auto_from_env() (embedding.rs:275-301)
- Checks CODEGRAPH_EMBEDDING_PROVIDER=lmstudio environment variable
- Performs availability check before enabling
- Matches with_config() implementation
2. Added lmstudio to feature flag checks (embedding.rs:120, 129)
- Ensures mut base is available when lmstudio feature is enabled
3. Exposed embeddings-lmstudio feature in MCP crate (Cargo.toml:91)
- Feature flag: embeddings-lmstudio = ["embeddings", "codegraph-vector/lmstudio"]
4. Updated Makefile build targets (Makefile:16, 21)
- Added embeddings-lmstudio to build-mcp-autoagents
- Added embeddings-lmstudio to build-mcp-http
The false alarm no longer appears and LM Studio embeddings work in all code paths.1 parent 9db3f6c commit d5b8f13
6 files changed
Lines changed: 36 additions & 7 deletions
File tree
- crates
- codegraph-mcp
- codegraph-vector/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
91 | 92 | | |
92 | 93 | | |
93 | 94 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
| 120 | + | |
120 | 121 | | |
121 | 122 | | |
122 | 123 | | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
127 | | - | |
| 128 | + | |
| 129 | + | |
128 | 130 | | |
129 | 131 | | |
130 | 132 | | |
| |||
270 | 272 | | |
271 | 273 | | |
272 | 274 | | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
273 | 301 | | |
274 | 302 | | |
275 | 303 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments