Skip to content

Bestiary drops table does not follow CanShowItemDropsInUI #210

Description

@haisen-no-yuuyake

This issue relates to the following messages in the Jopojelly Discord server, I am a contributor to Eidolon94's Gensokyo mod.
Image
This mod adds an armor set whose set bonus makes all enemies have a chance to drop a random food item. The IItemDropRuleCondition used for this effect overrides CanShowItemDropsInUI to return false, but these drops still show up in Recipe Browser's Bestiary.
Image

From the source code in this repository's 1.4 branch, it seems that Recipe Browser's Bestiary does not check CanShowItemDropsInUI, given the code block below from BestiaryUI.cs.
Image

However, when listing NPCs that could drop a certain Item, the mod does check CanShowItemDropsInUI, given the code block below. This is reflected in game as when looking for NPCs that can drop a specific food item with Recipe Browser and Gensokyo mod, NPCs that do not drop it normally are not shown.
Image

Is this inconsistency intentional? It seems that when tallying NPC loot, the mod ignores any global loot. Are mod developers supposed to use that to give loot to all enemies instead?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions