Skip to content

Commit 7a3d1b9

Browse files
committed
fix: Update tests to use new Error/Warning parameter order
Updated test calls to match the fixed parameter order: - Error(text, condition, code) instead of Error(text, code, condition) - Warning(text, condition, code) instead of Warning(text, code, condition) This fixes the test failures caused by commit ed674db.
1 parent ed674db commit 7a3d1b9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/JD.MSBuild.Fluent.Tests/CoverageTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ public void Fluent_builders_and_renderer_cover_surface()
5656
.Comment("inside-target")
5757
.Message("hello", "Low", "'m'=='1'")
5858
.Exec("echo hi", "C:\\", "'e'=='1'")
59-
.Error("err", "E1", "'er'=='1'")
60-
.Warning("warn", "W1", "'w'=='1'")
59+
.Error("err", "'er'=='1'", "E1")
60+
.Warning("warn", "'w'=='1'", "W1")
6161
.PropertyGroup("'p'=='1'", g => g.Property<PropertyPG>("V"), label: "Tpg")
6262
.ItemGroup("'i'=='1'", g => g.Include<MsBuildItemTypes.None>("x.txt"), label: "Tig")
6363
.Task(new DoStuffTaskName(), task => task

test/JD.MSBuild.Fluent.Tests/EfcptCanonicalParityTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,10 +400,10 @@ private static void RewriteTargetElement(TargetBuilder builder, MsBuildTargetEle
400400
builder.Exec(exec.Command, exec.WorkingDirectory, exec.Condition);
401401
break;
402402
case MsBuildErrorStep err:
403-
builder.Error(err.Text, err.Code, err.Condition);
403+
builder.Error(err.Text, err.Condition, err.Code);
404404
break;
405405
case MsBuildWarningStep warn:
406-
builder.Warning(warn.Text, warn.Code, warn.Condition);
406+
builder.Warning(warn.Text, warn.Condition, warn.Code);
407407
break;
408408
case MsBuildTaskStep task:
409409
builder.Task(new MsBuildTaskReference(task.TaskName), t => RewriteTask(t, task), task.Condition);

0 commit comments

Comments
 (0)