From 2c898a6ce23605c2bcfcaac9986f918eea4ccd99 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 5 Mar 2026 09:47:21 +0000 Subject: [PATCH] Simplify redundant conditional in create_instrumented_span The if/else block assigned the same expression to span_name, function_name, and method_name_only, calling split(/[#.]/).last twice in the true branch. Replaced with two clear variables: method_name_only and qualified_name. https://claude.ai/code/session_01KWZUse79XR68i6nGa8VgTu --- lib/observable/instrumenter.rb | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/lib/observable/instrumenter.rb b/lib/observable/instrumenter.rb index 6ac0a75..e8719c0 100644 --- a/lib/observable/instrumenter.rb +++ b/lib/observable/instrumenter.rb @@ -89,21 +89,13 @@ def determine_if_class_method def create_instrumented_span(caller_info, &block) separator = caller_info.is_class_method ? "." : "#" - - if caller_info.method_name.include?("#") || caller_info.method_name.include?(".") - span_name = "#{caller_info.namespace}#{separator}#{caller_info.method_name.split(/[#.]/).last}" - function_name = "#{caller_info.namespace}#{separator}#{caller_info.method_name.split(/[#.]/).last}" - method_name_only = caller_info.method_name.split(/[#.]/).last - else - span_name = "#{caller_info.namespace}#{separator}#{caller_info.method_name}" - function_name = "#{caller_info.namespace}#{separator}#{caller_info.method_name}" - method_name_only = caller_info.method_name - end + method_name_only = caller_info.method_name.split(/[#.]/).last + qualified_name = "#{caller_info.namespace}#{separator}#{method_name_only}" @last_captured_method_name = method_name_only @last_captured_namespace = caller_info.namespace - @tracer.in_span(span_name) do |span| - set_span_attributes(span, caller_info, function_name) + @tracer.in_span(qualified_name) do |span| + set_span_attributes(span, caller_info, qualified_name) begin result = block.call