From daa709e3b95e4b35eb304ef975f876f47e3d1ab1 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Sat, 14 Feb 2026 01:46:44 -0500 Subject: [PATCH] Fix some JET warning regarding matching methods for `strip(...)` and `parse(...)` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:210 │ no matching method found `parse(::Type{Int64}, ::Nothing)` (1/2 union split): SlurmClusterManager.parse(SlurmClusterManager.Int, (m::RegexMatch{String})[1]::Union{Nothing, SubString{String}}) └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:210 │ no matching method found `parse(::Type{Int64}, ::Nothing)` (1/2 union split): SlurmClusterManager.parse(SlurmClusterManager.Int, (m::RegexMatch{String})[1]::Union{Nothing, SubString{String}})::Int64 └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:211 │ no matching method found `strip(::Nothing)` (1/2 union split): SlurmClusterManager.strip((m::RegexMatch{String})[2]::Union{Nothing, SubString{String}}) └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:211 │ no matching method found `strip(::Nothing)` (1/2 union split): SlurmClusterManager.strip((m::RegexMatch{String})[2]::Union{Nothing, SubString{String}})::SubString{String} └──────────────────── ``` (cherry picked from commit 79b9476299cc72cf7b288c47191b71f6b9fca291) --- src/slurmmanager.jl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/slurmmanager.jl b/src/slurmmanager.jl index f0175c5..b62943c 100644 --- a/src/slurmmanager.jl +++ b/src/slurmmanager.jl @@ -205,10 +205,12 @@ function Distributed.launch(manager::SlurmManager, params::Dict, instances_arr:: line = readline(manager.srun_proc) m = match(r".*:(\d*)#(.*)", line) m === nothing && error("could not parse $line") + m[1] === nothing && error("could not extract port (m[1]) after parsing $line") + m[2] === nothing && error("could not extract host (m[2]) after parsing $line") config = WorkerConfig() - config.port = parse(Int, m[1]) - config.host = strip(m[2]) + config.port = parse(Int, m[1]::AbstractString) + config.host = strip(m[2]::AbstractString) @debug "Worker $i ready on host $(config.host), port $(config.port)"