Commit 1701a89
committed
Improve "Python not found dialog"
| Old | New |
| --- | --- |
| <img width="420"src="https://cloud.githubusercontent.com/assets/1570168/11857670/2a416ce2-a40f-11e5-9032-a07122bcb120.png"> | <img width="522"src="https://cloud.githubusercontent.com/assets/1570168/11857668/2a2d7db8-a40f-11e5-95ef-9da27016735b.png"> |
| New |
| --- |
| <img width="602"src="https://cloud.githubusercontent.com/assets/1570168/11857669/2a2dc854-a40f-11e5-99a4-cf29366c7885.png"> |
Rationale and changes:
- Permanent actions without a clear "undo" button are confusing for new users.
Change: The "Don't show this again" button is moved to a more "dangerous" location (where "Don't Save", a destructive action, normally appears)
- Modals can get really annoying, and some people will expect to open files with badly configured Pythons and not be faced with a modal.
Change: Add an setting "suppress_python_not_found_error" to permanently turn off modals
Change: Always error to console, even if modal turned off, for advanced users
- Change: aesthetic changes to dialog
- Change: add link to documentation
- Users might not know who is responsible for the dialog
Change: Add plugin name in dialog1 parent 9d79682 commit 1701a89
2 files changed
Lines changed: 50 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
376 | 397 | | |
377 | | - | |
378 | | - | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
379 | 403 | | |
380 | 404 | | |
381 | 405 | | |
| |||
0 commit comments