Parametrizing the logging calls to allow delayed string evaluation (saving a bit of CPU when the logging level is lower and the message is not processed)

Author: Lisias

Source/ModuleManager/Logging/IBasicLogger.cs

@@ -24,7 +24,7 @@ namespace ModuleManager.Logging
     public interface IBasicLogger
     {
         void Log(K.Level logType, string message, params object[] @params);
-        void Exception(Exception exception, string message);
+        void Exception(Exception exception, string message, params object[] @params);
         void Finish();
     }
 }

Source/ModuleManager/Logging/ModLogger.cs

@@ -25,7 +25,7 @@ public class ModLogger : IBasicLogger
         internal static readonly ModLogger Instance = new ModLogger(); // For legacy code
         internal static bool DebugMode => KSPe.Globals<ModuleManager>.DebugMode;
 
-        private delegate void LogMethod(string message, params object[] @parms);
+        private delegate void LogMethod(string message, params object[] @params);
         private readonly LogMethod[] methods;
         private ModLogger()
         {
@@ -41,9 +41,9 @@ private ModLogger()
 
         public void Log(K.Level logType, string message, params object[] @params) => this.methods[(int)logType](message, @params);
 
-        public void Exception(Exception exception, string message)
+        public void Exception(Exception exception, string message, params object[] @params)
         {
-            LOG.error(exception, message);
+            LOG.error(exception, message, @params);
         }
 
         public void Finish() { }

Source/ModuleManager/Logging/PatchLogger.cs

@@ -24,7 +24,7 @@ public class PatchLogger : IBasicLogger
         internal readonly K.Logger log;
         internal static bool DebugMode => KSPe.Globals<ModuleManager>.DebugMode;
 
-        private delegate void LogMethod(string message, params object[] @parms);
+        private delegate void LogMethod(string message, params object[] @params);
         private readonly LogMethod[] methods;
         internal PatchLogger(string filename)
         {
@@ -43,9 +43,9 @@ internal PatchLogger(string filename)
 
         public void Log(K.Level logType, string message, object[] @params) => this.methods[(int)logType](message, @params);
 
-        public void Exception(Exception exception, string message)
+        public void Exception(Exception exception, string message, params object[] @params)
         {
-            this.log.error(exception, message);
+            this.log.error(exception, message, @params);
         }
 
         public void Finish()

Source/ModuleManager/Progress/IPatchProgress.cs

@@ -25,11 +25,11 @@ public interface IPatchProgress
         EventVoid OnPatchApplied { get; }
         EventData<IPass> OnPassStarted { get; }
 
-        void Warning(UrlDir.UrlConfig url, string message);
-        void Error(UrlDir.UrlConfig url, string message);
-        void Error(string message);
-        void Exception(Exception exception, string message);
-        void Exception(Exception exception, UrlDir.UrlConfig url, string message);
+        void Warning(UrlDir.UrlConfig url, string message, params object[] @params);
+        void Error(UrlDir.UrlConfig url, string message, params object[] @params);
+        void Error(string message, params object[] @params);
+        void Exception(Exception exception, string message, params object[] @params);
+        void Exception(Exception exception, UrlDir.UrlConfig url, string message, params object[] @params);
         void NeedsUnsatisfiedRoot(UrlDir.UrlConfig url);
         void NeedsUnsatisfiedNode(UrlDir.UrlConfig url, string path);
         void NeedsUnsatisfiedValue(UrlDir.UrlConfig url, string path);

Source/ModuleManager/Progress/PatchProgress.cs

@@ -115,35 +115,35 @@ public void NeedsUnsatisfiedAfter(UrlDir.UrlConfig url)
             Counter.needsUnsatisfied.Increment();
         }
 
-        public void Warning(UrlDir.UrlConfig url, string message)
+        public void Warning(UrlDir.UrlConfig url, string message, params object[] @params)
         {
             Counter.warnings.Increment();
-            logger.Warning(message);
+            logger.Warning(message, @params);
             RecordWarningFile(url);
         }
 
-        public void Error(UrlDir.UrlConfig url, string message)
+        public void Error(UrlDir.UrlConfig url, string message, params object[] @params)
         {
             Counter.errors.Increment();
-            logger.Error(message);
+            logger.Error(message, @params);
             RecordErrorFile(url);
         }
 
-        public void Error(string message)
+        public void Error(string message, params object[] @params)
         {
             Counter.errors.Increment();
-            logger.Error(message);
+            logger.Error(message, @params);
         }
 
-        public void Exception(Exception exception, string message)
+        public void Exception(Exception exception, string message, params object[] @params)
         {
             Counter.exceptions.Increment();
-            logger.Exception(exception, message);
+            logger.Exception(exception, message, @params);
         }
 
-        public void Exception(Exception exception, UrlDir.UrlConfig url, string message)
+        public void Exception(Exception exception, UrlDir.UrlConfig url, string message, params object[] @params)
         {
-            Exception(exception, message);
+            Exception(exception, message, @params);
             RecordErrorFile(url);
         }