Use "L" for integer constants, use seq_len()

Author: hsonne

R/create_df_from_endnote_xml.R

@@ -14,24 +14,29 @@
 #' references_df <- create_df_from_endnote_xml()
 #' head(references_df)
 #'
-create_df_from_endnote_xml <- function(endnote_xml = default_xml()) {
+create_df_from_endnote_xml <- function(endnote_xml = default_xml())
+{
   references <- kwb.read::read_xml_as_path_value(endnote_xml)
 
   xml_paths <- references$path %>%
     stringr::str_remove_all(pattern = "^/xml/records/record")
 
   references_df <- kwb.utils::asNoFactorDataFrame(cbind(
     kwb.file::to_subdir_matrix(xml_paths),
-    references[, -1]
+    references[, -1L]
   ))
 
-  references_df[, 1] <- as.numeric(stringr::str_remove_all(
-    references_df[, 1], "\\[|\\]"
+  references_df[, 1L] <- as.numeric(stringr::str_remove_all(
+    references_df[, 1L], "\\[|\\]"
   ))
 
   n_col <- ncol(references_df)
 
-  colnames(references_df) <- c("record_id", paste0("key", 1:(n_col - 2)), "value")
+  colnames(references_df) <- c(
+    "record_id",
+    paste0("key", seq_len(n_col - 2L)),
+    "value"
+  )
 
   endnote_df <- dplyr::left_join(
     references_df,
@@ -41,7 +46,8 @@ create_df_from_endnote_xml <- function(endnote_xml = default_xml()) {
   add_file_info_attributes(endnote_df, endnote_xml)
 }
 
-if (FALSE) {
+if (FALSE)
+{
   abstracts <- references_df %>%
     dplyr::filter(.data$key1 == "abstract") %>%
     dplyr::group_by(