Skip to content

Commit 45498d1

Browse files
committed
refactor(ci): Simplify workflow by removing test-health job
The 'test-health' job has been removed to streamline the CI pipeline. Its primary responsibility, which was to check the application's health endpoint, is already covered within the integration tests of the 'test' job, making it redundant. This change simplifies the workflow, reduces potential points of failure, and slightly decreases the overall pipeline execution time.
1 parent 66b7032 commit 45498d1

1 file changed

Lines changed: 0 additions & 32 deletions

File tree

.github/workflows/test.yml

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -93,38 +93,6 @@ jobs:
9393
curl -f http://localhost:8080/health
9494
make stop
9595
96-
test-health:
97-
name: Test Health Checks
98-
needs: build
99-
runs-on: ubuntu-latest
100-
steps:
101-
- name: Checkout repository
102-
uses: actions/checkout@v4
103-
104-
- name: Create .env file for testing
105-
run: cp .env.example .env
106-
107-
- name: Log in to the GitHub Container Registry
108-
uses: docker/login-action@v3
109-
with:
110-
registry: ghcr.io
111-
username: ${{ github.actor }}
112-
password: ${{ secrets.GITHUB_TOKEN }}
113-
114-
- name: Pull and retag image
115-
run: |
116-
docker pull ${{ needs.build.outputs.image_tag }}
117-
docker tag ${{ needs.build.outputs.image_tag }} kariricode/php-api-stack:latest
118-
119-
- name: Run health checks
120-
run: |
121-
make build-test-image
122-
make run-test
123-
sleep 10
124-
make test-health
125-
curl -s http://localhost:8080/health.php | jq '.status' | grep -q "healthy"
126-
make stop-test
127-
12896
security:
12997
name: Security Scan
13098
needs: build

0 commit comments

Comments
 (0)