Skip to content

Commit 2e53dde

Browse files
authored
A couple of fixes to clCreateSemaphoreWithPropertiesKHR (#863)
- Remove an error case for CL_INVALID_VALUE. Invalid properties or property values are already covered by CL_INVALID_PROPERTY. - State clearly that CL_SEMAPHORE_TYPE_KHR must be pass when creating a semaphore in the table describing the property. This was previously just documented in the description for CL_INVALID_VALUE. Signed-off-by: Kévin Petit <kpet@free.fr> Signed-off-by: Kévin Petit <kpet@free.fr>
1 parent a897dfb commit 2e53dde

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

ext/cl_khr_semaphore.asciidoc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ Following new properties are added to the list of possible supported properties
256256
| Semaphore Property | Property Value | Description
257257
| {CL_SEMAPHORE_TYPE_KHR}
258258
| {cl_semaphore_type_khr_TYPE}
259-
| Specifies the type of semaphore to create.
259+
| Specifies the type of semaphore to create. This property is always required.
260260
| {CL_DEVICE_HANDLE_LIST_KHR}
261261
| {cl_device_id_TYPE}[]
262262
| Specifies the list of OpenCL devices (terminated with {CL_DEVICE_HANDLE_LIST_END_KHR}) to associate with the semaphore.
@@ -275,7 +275,6 @@ Otherwise, it returns a `NULL` value with one of the following error values retu
275275
* {CL_INVALID_VALUE}
276276
** if _sema_props_ is `NULL`, or
277277
** if _sema_props_ do not specify <property, value> pairs for minimum set of properties (i.e. {CL_SEMAPHORE_TYPE_KHR}) required for successful creation of a {cl_semaphore_khr_TYPE}, or
278-
** if one or more properties and/or their values specified by _sema_props_ are not valid.
279278
* {CL_OUT_OF_RESOURCES} if there is a failure to allocate resources required by the OpenCL implementation on the device.
280279
* {CL_OUT_OF_HOST_MEMORY} if there is a failure to allocate resources required by the OpenCL implementation on the host.
281280

0 commit comments

Comments
 (0)