Reference image update#158
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 79.93% 88.39% +8.45%
==========================================
Files 10 10
Lines 658 905 +247
==========================================
+ Hits 526 800 +274
+ Misses 132 105 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks a lot for the help! It was a struggle because everything worked well locally. It seems like that even with the correct reference image there are some small discrepancies that make the test fail. Also with the updated setup, the image comparison is not really useful... I will have a look into those things. |
Summary
refimages-v3release asset.@inoftypo that currently stopsreference/compare.jlbefore image comparison can run.basics/punctuation.pngandspacing/...pngupload useful images.Explanation
The current
ReferenceTestsworkflow fails before it can provide useful comparison artifacts. First, the script hits a typo in an added logging call. After that is fixed, nested reference image paths need their parent directories created beforesavewrites comparison figures.This PR keeps the existing release-asset model for reference images and changes the default reference tag from
refimages-v2torefimages-v3. The refreshed archive is not committed because*.taris ignored by the repository; it should be uploaded as thereference_images.tarasset for the newrefimages-v3release.Sorry for the extra follow-up here. This is only provided in case it might be useful; please ignore if not.
Refreshed archive candidate:
/private/tmp/MathTeXEngine-reference_images-refreshed.tarfaa877773479c148e600bf35de5573c4d87fbc4c2f80b0986af3a26c435b95c0Tests
git diff --check: passed.julia --project=reference --startup-file=no -e 'Meta.parseall(read("reference/compare.jl", String)); println("parse ok")': passed.REUSE_IMAGES_TAR=1 julia --project=reference --startup-file=no reference/compare.jl: passed, 23/23 reference images.julia --project=reference --startup-file=no reference/compare.jlagainst the currently publishedrefimages-v2: failed, 1 passed / 22 failed, but now writes comparison artifacts instead of crashing.