Skip to content

Commit 234e1ac

Browse files
authored
Update degree based Yereim bain hashmashos
Updated values based on the suggestion of Rabbi Yaakov Shakow.
1 parent 6d37722 commit 234e1ac

1 file changed

Lines changed: 26 additions & 26 deletions

File tree

src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -377,34 +377,34 @@ public class ComplexZmanimCalendar extends ZmanimCalendar {
377377
protected static final double ZENITH_9_POINT_75 = GEOMETRIC_ZENITH + 9.75;
378378

379379
/**
380-
* The zenith of 2.03° above {@link #GEOMETRIC_ZENITH geometric zenith} (90°). This calculation is used for
380+
* The zenith of 2.1° above {@link #GEOMETRIC_ZENITH geometric zenith} (90°). This calculation is used for
381381
* calculating the start of <em>bain hashmashos</em> (twilight) of 13.5 minutes before sunset converted to degrees
382382
* according to the Yereim. As is traditional with degrees below the horizon, this is calculated without refraction
383383
* and from the center of the sun. It would be 0.833&deg; less without this.
384384
*
385-
* @see #getBainHasmashosYereim2Point03Degrees()
385+
* @see #getBainHasmashosYereim2Point1Degrees()
386386
*/
387-
protected static final double ZENITH_MINUS_2_POINT_03 = GEOMETRIC_ZENITH - 2.03;
387+
protected static final double ZENITH_MINUS_2_POINT_1 = GEOMETRIC_ZENITH - 2.1;
388388

389389
/**
390-
* The zenith of 2.75&deg; above {@link #GEOMETRIC_ZENITH geometric zenith} (90&deg;). This calculation is used for
390+
* The zenith of 2.8&deg; above {@link #GEOMETRIC_ZENITH geometric zenith} (90&deg;). This calculation is used for
391391
* calculating the start of <em>bain hashmashos</em> (twilight) of 16.875 minutes before sunset converted to degrees
392392
* according to the Yereim. As is traditional with degrees below the horizon, this is calculated without refraction
393393
* and from the center of the sun. It would be 0.833&deg; less without this.
394394
*
395-
* @see #getBainHasmashosYereim2Point75Degrees()
395+
* @see #getBainHasmashosYereim2Point8Degrees()
396396
*/
397-
protected static final double ZENITH_MINUS_2_POINT_75 = GEOMETRIC_ZENITH - 2.75;
397+
protected static final double ZENITH_MINUS_2_POINT_8 = GEOMETRIC_ZENITH - 2.8;
398398

399399
/**
400-
* The zenith of 2.99&deg; above {@link #GEOMETRIC_ZENITH geometric zenith} (90&deg;). This calculation is used for
400+
* The zenith of 3.05&deg; above {@link #GEOMETRIC_ZENITH geometric zenith} (90&deg;). This calculation is used for
401401
* calculating the start of <em>bain hashmashos</em> (twilight) of 18 minutes before sunset converted to degrees
402402
* according to the Yereim. As is traditional with degrees below the horizon, this is calculated without refraction
403403
* and from the center of the sun. It would be 0.833&deg; less without this.
404404
*
405-
* @see #getBainHasmashosYereim2Point99Degrees()
405+
* @see #getBainHasmashosYereim3Point05Degrees()
406406
*/
407-
protected static final double ZENITH_MINUS_2_POINT_99 = GEOMETRIC_ZENITH - 2.99;
407+
protected static final double ZENITH_MINUS_3_POINT_05 = GEOMETRIC_ZENITH - 3.05;
408408

409409
/**
410410
* The offset in minutes (defaults to 40) after sunset used for <em>tzeit</em> for Ateret Torah calculations.
@@ -2038,7 +2038,7 @@ public Date getBainHasmashosRT2Stars() {
20382038
* Arctic Circle where there is at least one day a year where the sun does not rise, and one where it does
20392039
* not set, a null will be returned. See detailed explanation on top of the {@link AstronomicalCalendar}
20402040
* documentation.
2041-
* @see #getBainHasmashosYereim2Point99Degrees()
2041+
* @see #getBainHasmashosYereim3Point05Degrees()
20422042
*/
20432043
public Date getBainHasmashosYereim18Minutes() {
20442044
return getTimeOffset(getElevationAdjustedSunset(), -18 * MINUTE_MILLIS);
@@ -2052,16 +2052,16 @@ public Date getBainHasmashosYereim18Minutes() {
20522052
* minute <em>Mil</em> before sunset. According to the Yereim, bain hashmashos starts 3/4 of a <em>Mil</em> before
20532053
* sunset and <em>tzais</em> or nightfall starts at sunset.
20542054
*
2055-
* @return the <code>Date</code> of the sun's position 2.99&deg; minutes before sunset. If the calculation can't
2055+
* @return the <code>Date</code> of the sun's position 3.05&deg; minutes before sunset. If the calculation can't
20562056
* be computed such as in the Arctic Circle where there is at least one day a year where the sun does not
20572057
* rise, and one where it does not set, a null will be returned. See detailed explanation on top of the
20582058
* {@link AstronomicalCalendar} documentation.
20592059
*
2060-
* @see #ZENITH_MINUS_2_POINT_99
2060+
* @see #ZENITH_MINUS_3_POINT_05
20612061
* @see #getBainHasmashosYereim18Minutes()
20622062
*/
2063-
public Date getBainHasmashosYereim2Point99Degrees() {
2064-
return getSunsetOffsetByDegrees(ZENITH_MINUS_2_POINT_99);
2063+
public Date getBainHasmashosYereim3Point05Degrees() {
2064+
return getSunsetOffsetByDegrees(ZENITH_MINUS_3_POINT_05);
20652065
}
20662066

20672067
/**
@@ -2075,7 +2075,7 @@ public Date getBainHasmashosYereim2Point99Degrees() {
20752075
* not set, a null will be returned. See detailed explanation on top of the {@link AstronomicalCalendar}
20762076
* documentation.
20772077
*
2078-
* @see #getBainHasmashosYereim2Point75Degrees()
2078+
* @see #getBainHasmashosYereim2Point8Degrees()
20792079
*/
20802080
public Date getBainHasmashosYereim16Point875Minutes() {
20812081
return getTimeOffset(getElevationAdjustedSunset(), -16.875 * MINUTE_MILLIS);
@@ -2084,21 +2084,21 @@ public Date getBainHasmashosYereim16Point875Minutes() {
20842084
/**
20852085
* This method returns the beginning of <em>bain hashmashos</em> (twilight) according to the <a href=
20862086
* "https://en.wikipedia.org/wiki/Eliezer_ben_Samuel">Yereim (Rabbi Eliezer of Metz)</a> calculated as the sun's
2087-
* position 2.75&deg; above the horizon during the equinox (on March 16, about 4 days before the astronomical
2087+
* position 2.8&deg; above the horizon during the equinox (on March 16, about 4 days before the astronomical
20882088
* equinox, the day that a solar hour is 60 minutes) in Yerushalayim, its position 16.875 minutes or 3/4 of an 18
20892089
* minute <em>Mil</em> before sunset. According to the Yereim, bain hashmashos starts 3/4 of a <em>Mil</em> before
20902090
* sunset and <em>tzais</em> or nightfall starts at sunset.
20912091
*
2092-
* @return the <code>Date</code> of the sun's position 2.75&deg; minutes before sunset. If the calculation can't
2092+
* @return the <code>Date</code> of the sun's position 2.8&deg; minutes before sunset. If the calculation can't
20932093
* be computed such as in the Arctic Circle where there is at least one day a year where the sun does not
20942094
* rise, and one where it does not set, a null will be returned. See detailed explanation on top of the
20952095
* {@link AstronomicalCalendar} documentation.
20962096
*
2097-
* @see #ZENITH_MINUS_2_POINT_75
2097+
* @see #ZENITH_MINUS_2_POINT_8
20982098
* @see #getBainHasmashosYereim16Point875Minutes()
20992099
*/
2100-
public Date getBainHasmashosYereim2Point75Degrees() {
2101-
return getSunsetOffsetByDegrees(ZENITH_MINUS_2_POINT_75);
2100+
public Date getBainHasmashosYereim2Point8Degrees() {
2101+
return getSunsetOffsetByDegrees(ZENITH_MINUS_2_POINT_8);
21022102
}
21032103

21042104
/**
@@ -2112,7 +2112,7 @@ public Date getBainHasmashosYereim2Point75Degrees() {
21122112
* not set, a null will be returned. See detailed explanation on top of the {@link AstronomicalCalendar}
21132113
* documentation.
21142114
*
2115-
* @see #getBainHasmashosYereim2Point03Degrees()
2115+
* @see #getBainHasmashosYereim2Point1Degrees()
21162116
*/
21172117
public Date getBainHasmashosYereim13Point5Minutes() {
21182118
return getTimeOffset(getElevationAdjustedSunset(), -13.5 * MINUTE_MILLIS);
@@ -2121,21 +2121,21 @@ public Date getBainHasmashosYereim13Point5Minutes() {
21212121
/**
21222122
* This method returns the beginning of <em>bain hashmashos</em> according to the <a href=
21232123
* "https://en.wikipedia.org/wiki/Eliezer_ben_Samuel">Yereim (Rabbi Eliezer of Metz)</a> calculated as the sun's
2124-
* position 2.03&deg; above the horizon during the equinox (on March 16, about 4 days before the astronomical
2124+
* position 2.1&deg; above the horizon during the equinox (on March 16, about 4 days before the astronomical
21252125
* equinox, the day that a solar hour is 60 minutes) in Yerushalayim, its position 13.5 minutes or 3/4 of an 18
21262126
* minute <em>Mil</em> before sunset. According to the Yereim, bain hashmashos starts 3/4 of a <em>Mil</em> before
21272127
* sunset and <em>tzais</em> or nightfall starts at sunset.
21282128
*
2129-
* @return the <code>Date</code> of the sun's position 2.03&deg; minutes before sunset. If the calculation can't
2129+
* @return the <code>Date</code> of the sun's position 2.1&deg; minutes before sunset. If the calculation can't
21302130
* be computed such as in the Arctic Circle where there is at least one day a year where the sun does not
21312131
* rise, and one where it does not set, a null will be returned. See detailed explanation on top of the
21322132
* {@link AstronomicalCalendar} documentation.
21332133
*
2134-
* @see #ZENITH_MINUS_2_POINT_03
2134+
* @see #ZENITH_MINUS_2_POINT_1
21352135
* @see #getBainHasmashosYereim13Point5Minutes()
21362136
*/
2137-
public Date getBainHasmashosYereim2Point03Degrees() {
2138-
return getSunsetOffsetByDegrees(ZENITH_MINUS_2_POINT_03);
2137+
public Date getBainHasmashosYereim2Point1Degrees() {
2138+
return getSunsetOffsetByDegrees(ZENITH_MINUS_2_POINT_1);
21392139
}
21402140

21412141
/**

0 commit comments

Comments
 (0)