Shouldn't this be >= instead of >? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent to Math.max()?
|
return getMinchaGedola30Minutes().compareTo(getMinchaGedola()) > 0 ? getMinchaGedola30Minutes() |
Same for this:
|
return getMinchaGedola30Minutes().compareTo(getMinchaGedolaBaalHatanya()) > 0 ? getMinchaGedola30Minutes() |
Shouldn't this be
>=instead of>? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it). Is this not semantically equivalent toMath.max()?zmanim/src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java
Line 1860 in d24323b
Same for this:
zmanim/src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java
Line 4025 in d24323b