Skip to content

Commit ada17a0

Browse files
author
Yann Rouillard
committed
Revert "chore: parallelize gitops pre-commit check for faster execution"
Unfortunately this can lead to some issues with pickle in some cases.
1 parent 18fd758 commit ada17a0

1 file changed

Lines changed: 4 additions & 14 deletions

File tree

kp_pre_commit_hooks/gitops-values-validation.py

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import re
22
import sys
33
import textwrap
4-
from concurrent.futures import ProcessPoolExecutor as WorkerPool
54
from dataclasses import dataclass, field
65
from functools import cache, cached_property
76
from pathlib import Path
@@ -337,23 +336,17 @@ def display_errors(
337336
# Main code
338337
###############################################################################
339338

340-
341-
def validate_service_instance_config(service_instance_config):
342-
validator = ServiceInstanceConfigValidator(service_instance_config)
343-
return service_instance_config, validator.validate_configuration()
344-
345-
346339
if __name__ == "__main__":
347340
gitops_path = Path(sys.argv[1]) if len(sys.argv) >= 2 else Path.cwd()
348341
gitops_repository = GitOpsRepository(gitops_path)
349342

350343
try:
351344
errors_found = False
352-
353-
worker_pool = WorkerPool(max_workers=10)
354-
service_instances_config_iter = gitops_repository.iter_service_instances_config()
355-
for service_instance_config, errors in worker_pool.map(validate_service_instance_config, service_instances_config_iter):
345+
for service_instance_config in gitops_repository.iter_service_instances_config():
356346
print(f"Checking {service_instance_config} ", end="")
347+
348+
validator = ServiceInstanceConfigValidator(service_instance_config)
349+
errors = validator.validate_configuration()
357350
if not errors:
358351
print(green("PASSED"))
359352
else:
@@ -372,6 +365,3 @@ def validate_service_instance_config(service_instance_config):
372365
f" More info at {TWINGATE_DOC_URL}\n\n"
373366
)
374367
sys.exit(1)
375-
376-
finally:
377-
worker_pool.shutdown()

0 commit comments

Comments
 (0)