fix(FlowProviderMixin): stop all flows when stoping

Author: arlac77

README.md

@@ -39,10 +39,11 @@ possible to bundle steps in a flow. From the outside the flows acts as a single
 ### Table of Contents
 
 -   [Flow](#flow)
--   [createEndpoints](#createendpoints)
--   [endpointFor](#endpointfor)
--   [connectEndpoints](#connectendpoints)
--   [connectRootEndpoints](#connectrootendpoints)
+    -   [createEndpoints](#createendpoints)
+    -   [endpointFor](#endpointfor)
+    -   [connectEndpoints](#connectendpoints)
+    -   [connectRootEndpoints](#connectrootendpoints)
+    -   [name](#name)
 -   [willBeUnregistered](#willbeunregistered)
 
 ## Flow
@@ -51,13 +52,16 @@ possible to bundle steps in a flow. From the outside the flows acts as a single
 
 This is the flow implementation.
 It holds all the steps.
+Declares the following properties:
+\-steps
+\-autostart
 
 **Parameters**
 
--   `config`  
--   `owner`  
+-   `config`  {Object} The definition used to create the flow
+-   `owner`  {Object} owner of the flow
 
-## createEndpoints
+### createEndpoints
 
 The flow has no real endpoints. It only has proxies.
 So just return the configuration
@@ -66,7 +70,7 @@ So just return the configuration
 
 -   `stepDefinition` **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** The step configuration
 
-## endpointFor
+### endpointFor
 
 Find endpoint for given expression
 
@@ -78,20 +82,24 @@ Find endpoint for given expression
 
 Returns **Endpoint** found endpoint
 
-## connectEndpoints
+### connectEndpoints
 
 set the target endpoints
 
 **Parameters**
 
 -   `stepDefinition`  
 
-## connectRootEndpoints
+### connectRootEndpoints
 
 A flow has only endpoint proxies. These will be replaced by the original endpoints
 of the sub steps
 get the original endpoints for the Flow.
 
+### name
+
+Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 'kronos-flow'
+
 ## willBeUnregistered
 
 Deletes a flow from the stored flow definitions. If the flow

src/flow-provider-mixin.js

@@ -13,7 +13,7 @@ export function FlowProviderMixin(superclass) {
         withEvents: true,
         hasBeenRegistered: async flow => {
           if (flow.autostart) {
-            flow.start();
+            return flow.start();
           }
         },
 
@@ -30,5 +30,17 @@ export function FlowProviderMixin(superclass) {
         }
       });
     }
+
+    /**
+     * Stops execution and frees all used flows.
+     * It will stop each flow.
+     * @return {Promise} that fullfills when the manager has stopped
+     */
+    async _stop() {
+      await Promise.all(
+        Object.keys(this.flows).map(name => this.flows[name].stop())
+      );
+      return super._stop();
+    }
   };
 }

src/flow.js

@@ -10,12 +10,10 @@ export { FlowProviderMixin };
  * Declares the following properties:
  * -steps
  * -autostart
- * @param manager {object} The kronos-service-manager
- * @param name {string} The name of this step
- * @param stepDefinition {object} The definition used to create the step
+ * @param config {Object} The definition used to create the flow
+ * @param owner {Object} owner of the flow
  */
 export class Flow extends Step {
-
   /**
    * @return {string} 'kronos-flow'
    */

tests/flow-provider-test.js

@@ -0,0 +1,27 @@
+import { Service } from 'kronos-service';
+import { FlowProviderMixin } from '../src/flow-provider-mixin';
+import { Flow } from '../src/flow';
+import test from 'ava';
+
+class FlowProvider extends FlowProviderMixin(Service) {
+  static get name() {
+    return 'flow-provider';
+  }
+
+  get owner() {
+    return this;
+  }
+
+  // TODO
+  emit() {}
+}
+
+test('flow provider', async t => {
+  const fp = new FlowProvider();
+
+  await fp.start();
+
+  t.is(fp.state, 'running');
+
+  fp.registerFlow(Flow);
+});