Skip to content

Commit 11370ef

Browse files
authored
Merge pull request #168 from espadonne/disable-dropped-audio-submit-check
Disable dropped-audio submit check by default
2 parents 55b4952 + d308b5e commit 11370ef

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

components/recorder.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,12 @@ const createSilentAudio = () => {
103103

104104
const scratchURL = createSilentAudio();
105105

106-
export default function RecorderRefactored({ submit, accompaniment, logOperation = null }) {
106+
export default function RecorderRefactored({
107+
submit,
108+
accompaniment,
109+
logOperation = null,
110+
enableDroppedAudioDetection = false,
111+
}) {
107112
const dispatch = useDispatch();
108113
const router = useRouter();
109114
const { slug, piece, actCategory, partType } = router.query;
@@ -558,7 +563,9 @@ export default function RecorderRefactored({ submit, accompaniment, logOperation
558563
}
559564

560565
try {
561-
if (!ignoreSilence && ffmpegLoaded) {
566+
// Keep dropped-audio detection available as an opt-in tool without
567+
// blocking the default student submit flow.
568+
if (enableDroppedAudioDetection && !ignoreSilence && ffmpegLoaded) {
562569
const silenceResult = await catchSilence(
563570
ffmpegRef,
564571
url,
@@ -616,6 +623,7 @@ export default function RecorderRefactored({ submit, accompaniment, logOperation
616623
}
617624
},
618625
[
626+
enableDroppedAudioDetection,
619627
ignoreSilence,
620628
ffmpegLoaded,
621629
ffmpegRef,
@@ -749,7 +757,7 @@ export default function RecorderRefactored({ submit, accompaniment, logOperation
749757
</Col>
750758
</Row>
751759
<AudioDropModal
752-
show={showAudioDrop}
760+
show={enableDroppedAudioDetection && showAudioDrop}
753761
silenceData={silenceData}
754762
onIgnore={() => {
755763
setIgnoreSilence(true);

0 commit comments

Comments
 (0)