Skip to content

Commit fbb9058

Browse files
committed
Improve PVL validation
1 parent 444cbd7 commit fbb9058

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

SivStudies/src/org/labkey/sivstudies/query/ViralLoadsTriggerFactory.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ private void inspectResultValue(@NotNull Map<String, Object> row, ValidationExce
8888
{
8989
row.put("result", val);
9090
}
91-
else if (val.toLowerCase().startsWith("below"))
91+
else if (val.toLowerCase().contains("below"))
9292
{
93-
val = StringUtils.replaceIgnoreCase(val, "below ", "");
93+
val = StringUtils.trimToNull(val);
94+
val = StringUtils.replaceIgnoreCase(val, "below", "");
95+
val = StringUtils.trimToNull(val);
9496
if (NumberUtils.isCreatable(val))
9597
{
9698
row.put("result", val);
@@ -101,7 +103,7 @@ else if (val.toLowerCase().startsWith("below"))
101103

102104
if (!NumberUtils.isCreatable(val))
103105
{
104-
errors.addError(new SimpleValidationError("Non-numeric VL: "+ val, "result", ValidationException.SEVERITY.ERROR));
106+
errors.addError(new SimpleValidationError("Non-numeric VL: ["+ row.get("result") + "]", "result", ValidationException.SEVERITY.ERROR));
105107
}
106108
}
107109
}

0 commit comments

Comments
 (0)