Skip to content

Commit 93c0943

Browse files
authored
Replace AbstractContainerListener with ContainerListener default (#947)
1 parent e51611b commit 93c0943

8 files changed

Lines changed: 7 additions & 90 deletions

File tree

elisa/src/org/labkey/elisa/ElisaContainerListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import org.labkey.api.security.User;
66
import org.labkey.elisa.query.ElisaManager;
77

8-
public class ElisaContainerListener extends ContainerManager.AbstractContainerListener
8+
public class ElisaContainerListener implements ContainerManager.ContainerListener
99
{
1010
@Override
1111
public void containerDeleted(Container c, User user)

elisa/src/org/labkey/elisa/ElisaModule.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919
import org.jetbrains.annotations.NotNull;
2020
import org.jetbrains.annotations.Nullable;
2121
import org.labkey.api.assay.AssayService;
22-
import org.labkey.api.assay.plate.AbstractPlateBasedAssayProvider;
2322
import org.labkey.api.assay.plate.PlateService;
24-
import org.labkey.api.data.Container;
23+
import org.labkey.api.data.ContainerManager;
2524
import org.labkey.api.exp.api.ExperimentService;
2625
import org.labkey.api.module.DefaultModule;
2726
import org.labkey.api.module.ModuleContext;
@@ -75,18 +74,9 @@ protected void init()
7574
@Override
7675
public void doStartup(ModuleContext moduleContext)
7776
{
77+
ContainerManager.addContainerListener(new ElisaContainerListener());
7878
PlateService.get().registerPlateLayoutHandler(new ElisaPlateLayoutHandler());
7979
ExperimentService.get().registerExperimentDataHandler(new ElisaDataHandler());
80-
81-
AbstractPlateBasedAssayProvider provider = new ElisaAssayProvider();
82-
83-
AssayService.get().registerAssayProvider(provider);
84-
}
85-
86-
@NotNull
87-
@Override
88-
public Collection<String> getSummary(Container c)
89-
{
90-
return Collections.emptyList();
80+
AssayService.get().registerAssayProvider(new ElisaAssayProvider());
9181
}
9282
}

flow/src/org/labkey/flow/persist/FlowContainerListener.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,12 @@
1616

1717
package org.labkey.flow.persist;
1818

19-
import org.apache.logging.log4j.Logger;
20-
import org.apache.logging.log4j.LogManager;
2119
import org.labkey.api.data.Container;
2220
import org.labkey.api.data.ContainerManager;
2321
import org.labkey.api.security.User;
2422

25-
public class FlowContainerListener extends ContainerManager.AbstractContainerListener
23+
public class FlowContainerListener implements ContainerManager.ContainerListener
2624
{
27-
static final private Logger _log = LogManager.getLogger(FlowContainerListener.class);
28-
2925
/**
3026
* Delete all Flow data from the container.
3127
* This code should not really be necessary since all flow data should get deleted when the associated Experiment Data object is deleted.

flow/src/org/labkey/flow/query/FlowSchema.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@
124124
import org.labkey.flow.view.FlowQueryView;
125125
import org.springframework.validation.BindException;
126126

127-
import java.beans.PropertyChangeEvent;
128127
import java.util.ArrayList;
129128
import java.util.Arrays;
130129
import java.util.Collection;
@@ -1974,11 +1973,6 @@ public void containerDeleted(Container c, User user)
19741973
{
19751974
fastflowCache.removeUsingFilter(new Cache.StringPrefixFilter(c.getId() + "/"));
19761975
}
1977-
1978-
@Override public void containerCreated(Container c, User user) { }
1979-
@Override public void containerMoved(Container c, Container oldParent, User user) { }
1980-
@NotNull @Override public Collection<String> canMove(Container c, Container newParent, User user) { return Collections.emptyList(); }
1981-
@Override public void propertyChange(PropertyChangeEvent evt) { }
19821976
};
19831977

19841978
public static void registerContainerListener()

microarray/src/org/labkey/microarray/MicroarrayContainerListener.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,7 @@
1919
import org.labkey.api.data.ContainerManager;
2020
import org.labkey.api.security.User;
2121

22-
/**
23-
* User: bbimber
24-
* Date: 2/23/12
25-
* Time: 4:42 PM
26-
*/
27-
public class MicroarrayContainerListener extends ContainerManager.AbstractContainerListener
22+
public class MicroarrayContainerListener implements ContainerManager.ContainerListener
2823
{
2924
@Override
3025
public void containerDeleted(Container c, User user)
Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,15 @@
11
package org.labkey.ms2;
22

3-
import org.jetbrains.annotations.NotNull;
43
import org.labkey.api.data.Container;
54
import org.labkey.api.data.ContainerManager;
65
import org.labkey.api.security.User;
76

8-
import java.beans.PropertyChangeEvent;
9-
import java.util.Collection;
10-
import java.util.Collections;
11-
127
public class MS2ContainerListener implements ContainerManager.ContainerListener
138
{
14-
@Override
15-
public void containerCreated(Container c, User user)
16-
{
17-
}
18-
199
@Override
2010
public void containerDeleted(Container c, User user)
2111
{
2212
MS2Manager.markAsDeleted(c, user);
2313
MS2Manager.deleteExpressionData(c);
2414
}
25-
26-
@Override
27-
public void containerMoved(Container c, Container oldParent, User user)
28-
{
29-
}
30-
31-
@NotNull
32-
@Override
33-
public Collection<String> canMove(Container c, Container newParent, User user)
34-
{
35-
return Collections.emptyList();
36-
}
37-
38-
@Override
39-
public void propertyChange(PropertyChangeEvent evt)
40-
{
41-
}
4215
}

nab/src/org/labkey/nab/NabContainerListener.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,7 @@
1919
import org.labkey.api.data.ContainerManager;
2020
import org.labkey.api.security.User;
2121

22-
/**
23-
* User: adam
24-
* Date: Nov 5, 2008
25-
* Time: 3:09:06 PM
26-
*/
27-
public class NabContainerListener extends ContainerManager.AbstractContainerListener
22+
public class NabContainerListener implements ContainerManager.ContainerListener
2823
{
2924
@Override
3025
public void containerDeleted(Container c, User user)

protein/src/org/labkey/protein/ProteinContainerListener.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,14 @@
1616

1717
package org.labkey.protein;
1818

19-
import org.jetbrains.annotations.NotNull;
2019
import org.labkey.api.data.Container;
2120
import org.labkey.api.data.ContainerManager.ContainerListener;
2221
import org.labkey.api.protein.annotation.CustomAnnotationSet;
2322
import org.labkey.api.protein.annotation.CustomAnnotationSetManager;
2423
import org.labkey.api.security.User;
2524

26-
import java.beans.PropertyChangeEvent;
27-
import java.util.Collection;
28-
import java.util.Collections;
29-
3025
public class ProteinContainerListener implements ContainerListener
3126
{
32-
@Override
33-
public void containerCreated(Container c, User user)
34-
{
35-
}
36-
3727
@Override
3828
public void containerDeleted(Container c, User user)
3929
{
@@ -42,20 +32,4 @@ public void containerDeleted(Container c, User user)
4232
CustomAnnotationSetManager.deleteCustomAnnotationSet(set);
4333
}
4434
}
45-
46-
@Override
47-
public void propertyChange(PropertyChangeEvent evt)
48-
{
49-
}
50-
51-
@Override
52-
public void containerMoved(Container c, Container oldParent, User user)
53-
{
54-
}
55-
56-
@NotNull @Override
57-
public Collection<String> canMove(Container c, Container newParent, User user)
58-
{
59-
return Collections.emptyList();
60-
}
6135
}

0 commit comments

Comments
 (0)