Skip to content

Commit b5c5676

Browse files
committed
Stricter checks on namespace prefixes
1 parent 3f4a9f7 commit b5c5676

2 files changed

Lines changed: 12 additions & 14 deletions

File tree

ehr/api-src/org/labkey/api/ehr/security/EHRSecurityEscalatorAuditProvider.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package org.labkey.api.ehr.security;
1717

18-
import org.labkey.api.audit.query.AbstractAuditDomainKind;
1918
import org.labkey.api.data.Container;
2019
import org.labkey.api.study.security.SecurityEscalationAuditProvider;
2120

@@ -27,8 +26,14 @@ public class EHRSecurityEscalatorAuditProvider extends SecurityEscalationAuditPr
2726
public static String EVENT_TYPE = EHRSecurityEscalationEvent.class.getSimpleName();
2827
public static String AUDIT_LOG_TITLE = "EHR Security Escalations";
2928

29+
public EHRSecurityEscalatorAuditProvider()
30+
{
31+
super(new EHRSecurityEscalationDomainKind());
32+
}
33+
3034
@Override
31-
public String getDescription() {
35+
public String getDescription()
36+
{
3237
return "This audits all uses of the EHR Security Escalation";
3338
}
3439

@@ -47,12 +52,6 @@ public String getAuditLogTitle() {
4752
return AUDIT_LOG_TITLE;
4853
}
4954

50-
@Override
51-
protected AbstractAuditDomainKind getDomainKind()
52-
{
53-
return new EHRSecurityEscalationDomainKind();
54-
}
55-
5655
public static class EHRSecurityEscalationEvent extends SecurityEscalationEvent
5756
{
5857
/** Important for reflection-based instantiation */

snd/src/org/labkey/snd/NarrativeAuditProvider.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ public class NarrativeAuditProvider extends AbstractAuditTypeProvider implements
4242
public static final String COLUMN_NAME_EVENTDATE = "EventDate";
4343
public static final String COLUMN_NAME_QCSTATE = "QcState";
4444

45-
static final List<FieldKey> defaultVisibleColumns = new ArrayList<>();
46-
47-
static {
45+
private static final List<FieldKey> defaultVisibleColumns = new ArrayList<>();
4846

47+
static
48+
{
4949
defaultVisibleColumns.add(FieldKey.fromParts(COLUMN_NAME_CREATED));
5050
defaultVisibleColumns.add(FieldKey.fromParts(COLUMN_NAME_CREATED_BY));
5151
defaultVisibleColumns.add(FieldKey.fromParts(COLUMN_NAME_IMPERSONATED_BY));
@@ -57,10 +57,9 @@ public class NarrativeAuditProvider extends AbstractAuditTypeProvider implements
5757
defaultVisibleColumns.add(FieldKey.fromParts(COLUMN_NAME_QCSTATE));
5858
}
5959

60-
@Override
61-
protected AbstractAuditDomainKind getDomainKind()
60+
public NarrativeAuditProvider()
6261
{
63-
return new org.labkey.snd.NarrativeAuditProvider.NarrativeAuditDomainKind();
62+
super(new NarrativeAuditDomainKind());
6463
}
6564

6665
@Override

0 commit comments

Comments
 (0)