Additional validation for assay run configurations (#118)

labkey-klum · web-flow · commit 0ec3cc5fc41e · 2025-07-22T12:47:09.000-07:00
diff --git a/Rlabkey/DESCRIPTION b/Rlabkey/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: Rlabkey
-Version: 3.4.3
+Version: 3.4.4
 Date: 2025-05-12
 Title: Data Exchange Between R and 'LabKey' Server
 Authors@R: c(person(given = "Peter",
diff --git a/Rlabkey/NEWS b/Rlabkey/NEWS
@@ -1,3 +1,6 @@
+Changes in 3.4.4
+  o Issue 53481: additional validation for assay run configurations.
+
 Changes in 3.4.3
   o Bugfix to labkey.selectRows when group_concat based field has a NULL value. Related to github issue #112
   o Update documentation for experiment.createRun to include an example of inserting run level properties
diff --git a/Rlabkey/R/labkey.experiment.R b/Rlabkey/R/labkey.experiment.R
@@ -74,6 +74,10 @@ labkey.experiment.createRun <- function(config, dataInputs = NULL, dataOutputs =
 
     run <- config
 
+    ## validate run properties if provided
+    if (!is.null(run$properties) && !is.list(run$properties))
+        stop (paste("config properties must be a list of key value pairs."))
+
     if (!is.null(dataInputs))
     {
         if (!is.list(dataInputs))

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,10 @@ labkey.experiment.createRun <- function(config, dataInputs = NULL, dataOutputs =`
`74`	`74`
`75`	`75`	`run <- config`
`76`	`76`
	`77`	`+ ## validate run properties if provided`
	`78`	`+ if (!is.null(run$properties) && !is.list(run$properties))`
	`79`	`+ stop (paste("config properties must be a list of key value pairs."))`
	`80`	`+`
`77`	`81`	`if (!is.null(dataInputs))`
`78`	`82`	`{`
`79`	`83`	`if (!is.list(dataInputs))`