Add check for empty arrays in listToMatrix (#115)

bbimber · web-flow · commit 1516d8949471 · 2025-03-28T14:58:47.000-05:00
- note that we have another Rlabkey change coming soon in another PR so will wait for that to publish the updated version
diff --git a/Rlabkey/DESCRIPTION b/Rlabkey/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: Rlabkey
-Version: 3.4.2
-Date: 2025-03-12
+Version: 3.4.3
+Date: 2025-03-21
 Title: Data Exchange Between R and 'LabKey' Server
 Authors@R: c(person(given = "Peter",
                     family = "Hussey",
diff --git a/Rlabkey/NEWS b/Rlabkey/NEWS
@@ -1,3 +1,6 @@
+Changes in 3.4.3
+  o Bugfix to labkey.selectRows when group_concat based field has a NULL value. Related to github issue #112
+
 Changes in 3.4.2
   o Add showProgressBar parameter to labkey.webdav.downloadFolder and labkey.webdav.get
 
diff --git a/Rlabkey/src/listToMatrix.cpp b/Rlabkey/src/listToMatrix.cpp
@@ -37,7 +37,7 @@ CharacterMatrix listToMatrix(List data, List names) {
         {
           // only try to parse the first vector element as a string if it is non-null
           GenericVector gv = as<GenericVector>((as<List>(data[i]))[as<int>(indexList[j])]);
-          if(!Rf_isNull(gv[0]))
+          if(gv.size() > 0 && !Rf_isNull(gv[0]))
           {
             cMatrix(i,j) = as<CharacterVector>(gv[0])[0];
           }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ CharacterMatrix listToMatrix(List data, List names) {`
`37`	`37`	`{`
`38`	`38`	`// only try to parse the first vector element as a string if it is non-null`
`39`	`39`	`GenericVector gv = as<GenericVector>((as<List>(data[i]))[as<int>(indexList[j])]);`
`40`		`- if(!Rf_isNull(gv[0]))`
	`40`	`+ if(gv.size() > 0 && !Rf_isNull(gv[0]))`
`41`	`41`	`{`
`42`	`42`	`cMatrix(i,j) = as<CharacterVector>(gv[0])[0];`
`43`	`43`	`}`