Skip to content

Commit 0c13a39

Browse files
authored
Issue 54186: App actions are missing TransactionAuditEvent (#1890)
1 parent f5daf49 commit 0c13a39

6 files changed

Lines changed: 21 additions & 6 deletions

File tree

packages/components/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@labkey/components",
3-
"version": "6.70.4",
3+
"version": "6.70.5",
44
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
55
"sideEffects": false,
66
"files": [

packages/components/releaseNotes/components.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
# @labkey/components
22
Components, models, actions, and utility functions for LabKey applications and pages
33

4+
### version 6.70.5
5+
*Released*: 13 November 2025
6+
- Issue 54186: App actions for picklists and assay run delete don't get TransactionAuditEvent
7+
- Add 'auditBehavior' to insertRows, updateRows, deleteRows usages so app actions get TransactionAuditEvent
8+
49
### version 6.70.4
510
*Released*: 13 November 2025
611
- Ability to show identifying fields during assay import of a single sample type

packages/components/src/internal/components/forms/actions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
import { PermissionTypes, Security, User } from '@labkey/api';
16+
import { AuditBehaviorTypes, PermissionTypes, Security, User } from '@labkey/api';
1717
import { useCallback, useEffect, useState } from 'react';
1818

1919
import { updateRows } from '../../query/api';
@@ -127,5 +127,6 @@ export function updateRowFieldValue(model: QueryModel, name: string, value: any)
127127
},
128128
],
129129
containerPath: model.containerPath,
130+
auditBehavior: AuditBehaviorTypes.DETAILED,
130131
});
131132
}

packages/components/src/internal/components/picklist/actions.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Domain, Filter, Query } from '@labkey/api';
1+
import { AuditBehaviorTypes, Domain, Filter, Query } from '@labkey/api';
22

33
import { List } from 'immutable';
44

@@ -220,7 +220,11 @@ export async function addSamplesToPicklist(listName: string, sampleIds: number[]
220220
const schemaQuery = new SchemaQuery(SCHEMAS.PICKLIST_TABLES.SCHEMA, listName);
221221

222222
if (rows.size > 0) {
223-
return await insertRows({ schemaQuery, rows });
223+
return await insertRows({
224+
schemaQuery,
225+
rows,
226+
auditBehavior: AuditBehaviorTypes.DETAILED,
227+
});
224228
}
225229

226230
return new QueryCommandResponse({

packages/components/src/internal/components/samples/ManageSampleStatusesPanel.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import React, { FC, memo, useCallback, useEffect, useMemo, useState } from 'react';
22
import { List } from 'immutable';
33

4+
import { AuditBehaviorTypes } from '@labkey/api';
5+
46
import { LoadingSpinner } from '../base/LoadingSpinner';
57
import { Alert } from '../base/Alert';
68
import { LockIcon } from '../base/LockIcon';
@@ -157,6 +159,7 @@ export const SampleStatusDetail: FC<SampleStatusDetailProps> = memo(props => {
157159
schemaQuery: SCHEMAS.CORE_TABLES.DATA_STATES,
158160
rows: [stateToSave],
159161
containerPath: container?.path,
162+
auditBehavior: AuditBehaviorTypes.DETAILED,
160163
})
161164
.then(() => {
162165
onActionComplete(stateToSave.label);
@@ -171,6 +174,7 @@ export const SampleStatusDetail: FC<SampleStatusDetailProps> = memo(props => {
171174
schemaQuery: SCHEMAS.CORE_TABLES.DATA_STATES,
172175
rows: List([stateToSave]),
173176
containerPath: container?.path,
177+
auditBehavior: AuditBehaviorTypes.DETAILED,
174178
})
175179
.then(() => {
176180
onActionComplete(stateToSave.label);
@@ -192,6 +196,7 @@ export const SampleStatusDetail: FC<SampleStatusDetailProps> = memo(props => {
192196
schemaQuery: SCHEMAS.CORE_TABLES.DATA_STATES,
193197
containerPath: container?.path,
194198
rows: [updatedState],
199+
auditBehavior: AuditBehaviorTypes.DETAILED,
195200
})
196201
.then(() => {
197202
onActionComplete(undefined, true);

0 commit comments

Comments
 (0)