Issue 53120: remove processRequest, use getCallbackWrapper (#1814)

Author: labkey-nicka

packages/components/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/components",
-  "version": "6.52.0",
+  "version": "6.52.1",
   "description": "Components, models, actions, and utility functions for LabKey applications and pages",
   "sideEffects": false,
   "files": [

packages/components/package.json

@@ -1,6 +1,10 @@
 # @labkey/components
 Components, models, actions, and utility functions for LabKey applications and pages
 
+### version 6.52.1
+*Released*: 25 June 2025
+- Issue 53120: remove processRequest, use getCallbackWrapper
+
 ### version 6.52.0
 *Released*: 24 June 2025
 - Improve ExecuteSql endpoint wrapper. See #1813.

packages/components/releaseNotes/components.md

@@ -491,14 +491,6 @@ export async function selectRowsDeprecated(options: SelectRowsDeprecatedOptions)
                     resolve(response_);
                 },
                 failure: (data, request) => {
-                    // If we hit a communication failure, try to get better error messaging from the request.responseText (Issues 51232 and 51204)
-                    if (
-                        data.exception?.toLowerCase().indexOf('communication failure') === 0 &&
-                        processRequest(undefined, request, reject)
-                    ) {
-                        return;
-                    }
-
                     console.error('There was a problem retrieving the data', data);
                     reject({
                         exceptionClass: data.exceptionClass,
@@ -803,9 +795,7 @@ export function insertRows(options: InsertRowsOptions): Promise<QueryCommandResp
                     ? true
                     : options.skipReselectRows,
             apiVersion: 13.2,
-            success: (response, request) => {
-                if (processRequest(response, request, reject)) return;
-
+            success: response => {
                 resolve(
                     new QueryCommandResponse({
                         schemaQuery,
@@ -886,9 +876,7 @@ export function updateRows(options: UpdateRowsOptions): Promise<QueryCommandResp
                 options.skipReselectRows === null || options.skipReselectRows === undefined
                     ? true
                     : options.skipReselectRows,
-            success: (response, request) => {
-                if (processRequest(response, request, reject)) return;
-
+            success: response => {
                 resolve(
                     new QueryCommandResponse({
                         schemaQuery,
@@ -1151,19 +1139,6 @@ export function importData(config: IImportData): Promise<any> {
     });
 }
 
-export function processRequest(response: any, request: any, reject: (reason?: any) => void): boolean {
-    if (!response && request?.responseText) {
-        const resp = JSON.parse(request.responseText);
-        if (!resp?.success) {
-            console.error(resp);
-            reject(resp);
-            return true;
-        }
-    }
-
-    return false;
-}
-
 /**
  * Provides the default ContainerFilter to utilize when requesting data cross-folder.
  * This ContainerFilter is applied to all `executeSql` and `selectRows` requests made via the methods

packages/components/src/internal/query/api.ts

@@ -1,16 +1,17 @@
-import { Ajax, Utils } from '@labkey/api';
+import { ActionURL } from '@labkey/api';
 
 import { IDataViewInfo } from '../DataViewInfo';
-import { AppURL, buildURL } from '../url/AppURL';
+import { AppURL } from '../url/AppURL';
+import { request } from '../request';
 
 export type ReportURLMapper = (report: IDataViewInfo) => AppURL;
 
 /**
  * FlattenResponse converts the response body (a nested tree structure) from browseDataTree into a flat list of
  * ReportItem objects. This method purposely ignores categories and their nested structures.
  *
- * @param response: the body from the browseDataTree API Action
- * @param urlMapper: ReportURLMapper
+ * @param response the body from the browseDataTree API Action
+ * @param urlMapper ReportURLMapper
  */
 export function flattenBrowseDataTreeResponse(response: any, urlMapper?: ReportURLMapper): IDataViewInfo[] {
     function _flattenBrowseDataTreeResponse(all, item): IDataViewInfo[] {
@@ -32,22 +33,11 @@ export function flattenBrowseDataTreeResponse(response: any, urlMapper?: ReportU
     return _flattenBrowseDataTreeResponse([], response);
 }
 
-export function loadReports(urlMapper?: ReportURLMapper): Promise<IDataViewInfo[]> {
-    return new Promise((resolve, reject) => {
-        Ajax.request({
-            method: 'GET',
-            url: buildURL('reports', 'browseDataTree.api'),
-            success: request => {
-                const reports = flattenBrowseDataTreeResponse(JSON.parse(request.responseText), urlMapper);
-                resolve(reports);
-            },
-            failure: Utils.getCallbackWrapper(
-                error => {
-                    reject(error);
-                },
-                this,
-                true
-            ),
-        });
+export async function loadReports(urlMapper?: ReportURLMapper): Promise<IDataViewInfo[]> {
+    const result = await request({
+        url: ActionURL.buildURL('reports', 'browseDataTree.api'),
+        errorLogMsg: 'Failed to load reports',
     });
+
+    return flattenBrowseDataTreeResponse(result, urlMapper);
 }