Issue 868: Add more nouns for count units (#1975)

Author: labkey-susanh

packages/components/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/components",
-  "version": "7.28.2",
+  "version": "7.29.1",
   "description": "Components, models, actions, and utility functions for LabKey applications and pages",
   "sideEffects": false,
   "files": [

packages/components/package.json

@@ -1,9 +1,13 @@
 # @labkey/components
 Components, models, actions, and utility functions for LabKey applications and pages
 
+### version 7.29.1
+*Released*: 7 April 2026
+- GitHub Issue 868: Add more nouns for count units
+
 ### version 7.28.2
 *Released*: 7 April 2026
-- Update `FEEZER_ITEM_SAMPLE_MAPPER` to return undefined if not matched, for consistency with other mappers
+- Update `FREEZER_ITEM_SAMPLE_MAPPER` to return undefined if not matched, for consistency with other mappers
 
 ### version 7.28.1
 *Released*: 3 April 2026

packages/components/releaseNotes/components.md

@@ -53,9 +53,11 @@ import {
     getMeasurementUnit,
     getMetricUnitOptions,
     getMetricUnitOptionsFromKind,
+    MEASUREMENT_UNITS,
     UNITS_KIND,
 } from '../../../util/measurement';
 import { Alert } from '../../base/Alert';
+import { makeCommaSeparatedString } from '../../../util/utils';
 
 const PROPERTIES_HEADER_ID = 'sample-type-properties-hdr';
 const ALIQUOT_HELP_LINK = getHelpLink('aliquotIDs');
@@ -94,7 +96,7 @@ export const UnitKinds: Record<UNITS_KIND, UnitKindType> = {
         value: UNITS_KIND.COUNT,
         label: 'Other',
         hideSubSelect: true,
-        msg: "Amounts can be entered as bottles, blocks, boxes, cells, kits, packs, pieces, slides, tests, or unit and won't be converted.",
+        msg: "Amounts can be entered as " +  makeCommaSeparatedString(MEASUREMENT_UNITS.unit.altLabels, ', or ') + " and won't be converted",
     },
 };
 

packages/components/src/internal/components/domainproperties/samples/SampleTypePropertiesPanel.tsx

@@ -11,6 +11,7 @@ import { FormsyInput } from './FormsyReactComponents';
 import { Operation } from '../../../../public/QueryColumn';
 import { STORED_AMOUNT_FIELDS } from '../../samples/constants';
 import { Alert } from '../../base/Alert';
+import { LOOKUP_DEFAULT_SIZE } from '../../../constants';
 
 export const AmountUnitInput: FC<InputRendererProps> = memo(props => {
     const {
@@ -102,6 +103,7 @@ export const AmountUnitInput: FC<InputRendererProps> = memo(props => {
                     id={id}
                     inputClass={''}
                     name={unitCol.fieldKey}
+                    maxRows={LOOKUP_DEFAULT_SIZE}
                     onQSChange={onSelectChange}
                     placeholder="Select or type to search..."
                     queryFilters={queryFilter}

packages/components/src/internal/components/forms/input/AmountUnitInput.tsx

@@ -134,9 +134,9 @@ describe('MetricUnit utils', () => {
             ])
         );
 
-        expect(getMetricUnitOptions(null).length).toBe(18);
-        expect(getMetricUnitOptions('').length).toBe(18);
-        expect(getMetricUnitOptions('bad').length).toBe(18);
+        expect(getMetricUnitOptions(null).length).toBe(22);
+        expect(getMetricUnitOptions('').length).toBe(22);
+        expect(getMetricUnitOptions('bad').length).toBe(22);
     });
 
     test('getMetricUnitOptions with filterFn', () => {
@@ -197,17 +197,21 @@ describe('MetricUnit utils', () => {
             'boxes',
             'cells',
             'kits',
+            'organisms',
             'packs',
             'pieces',
             'slides',
+            'syringes',
             'tests',
+            'tubes',
             'unit',
+            'vials',
         ]);
 
         // include all options when no unitTypeStr or an invalid unitTypeStr is provided
-        expect(getAltUnitKeys(null).length).toBe(18);
-        expect(getAltUnitKeys('').length).toBe(18);
-        expect(getAltUnitKeys('bad').length).toBe(18);
+        expect(getAltUnitKeys(null).length).toBe(22);
+        expect(getAltUnitKeys('').length).toBe(22);
+        expect(getAltUnitKeys('bad').length).toBe(22);
     });
 
     test('getMeasurementUnit', () => {

packages/components/src/internal/util/measurement.test.ts

@@ -181,7 +181,7 @@ export const MEASUREMENT_UNITS: Record<string, MeasurementUnit> = {
         kind: UNITS_KIND.COUNT,
         ratio: 1,
         displayPrecision: 2,
-        altLabels: ['blocks', 'bottles', 'boxes', 'cells', 'kits', 'packs', 'pieces', 'slides', 'tests', 'unit'],
+        altLabels: ['blocks', 'bottles', 'boxes', 'cells', 'kits', 'organisms', 'packs', 'pieces', 'slides', 'syringes', 'tests', 'tubes', 'unit', 'vials'],
     },
 };