GitHub Issue 974: Lookup data type incorrectly shown in app assay designer (#1971)

### version 7.21.4
*Released*: 6 April 2026
- GitHub Issue #974: Lookup Data Type shown in Assay Designer for app, even when premium module is not present
  - AssayDesignerPanels to pass appPropertiesOnly to AssayDomainForm
  - add new domainFormDisplayOptions.showAdvancedSettingsForApp for assay designer case

Author: cnathe

packages/components/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/components",
-  "version": "7.21.3",
+  "version": "7.21.4",
   "description": "Components, models, actions, and utility functions for LabKey applications and pages",
   "sideEffects": false,
   "files": [

packages/components/package.json

@@ -1,6 +1,12 @@
 # @labkey/components
 Components, models, actions, and utility functions for LabKey applications and pages
 
+### version 7.21.4
+*Released*: 6 April 2026
+- GitHub Issue #974: Lookup Data Type shown in Assay Designer for app, even when premium module is not present
+  - AssayDesignerPanels to pass appPropertiesOnly to AssayDomainForm
+  - add new domainFormDisplayOptions.showAdvancedSettingsForApp for assay designer case
+
 ### version 7.21.3
 *Released*: 12 March 2026
 - GitHub Issue #790: Sample check-in and discard should not allow amount/unit input for differing units

packages/components/releaseNotes/components.md

@@ -395,7 +395,10 @@ export class DomainRow extends React.PureComponent<DomainRowProps, DomainRowStat
         const draggableId = createFormInputId('domaindrag', domainIndex, index);
         // Use undefined instead of false to allow for css to handle the highlight color for hover
         const highlighted = dragging ? true : isDragDisabled ? false : undefined;
-        const showAdvancedSettingsButton = expanded && !isFieldFullyLocked(field.lockType) && !appPropertiesOnly;
+        const showAdvancedSettingsButton =
+            expanded &&
+            !isFieldFullyLocked(field.lockType) &&
+            (!appPropertiesOnly || domainFormDisplayOptions?.showAdvancedSettingsForApp); // GitHub Issue #974
 
         return (
             <Draggable

packages/components/src/internal/components/domainproperties/DomainRow.tsx

@@ -39,14 +39,16 @@ import { FilterCriteriaContext } from './FilterCriteriaContext';
 const PROPERTIES_PANEL_INDEX = 0;
 const DOMAIN_PANEL_INDEX = 1;
 
-interface AssayDomainFormProps
-    extends Omit<InjectedBaseDomainDesignerProps, 'onFinish' | 'setSubmitting' | 'submitting'> {
+interface AssayDomainFormProps extends Omit<
+    InjectedBaseDomainDesignerProps,
+    'onFinish' | 'setSubmitting' | 'submitting'
+> {
     api: DomainPropertiesAPIWrapper;
     appDomainHeaders: Map<string, HeaderRenderer>;
+    appPropertiesOnly?: boolean;
     domain: DomainDesign;
     domainFormDisplayOptions: IDomainFormDisplayOptions;
     headerPrefix: string;
-    hideAdvancedProperties?: boolean;
     index: number;
     onDomainChange: (
         index: number,
@@ -67,7 +69,7 @@ const AssayDomainForm: FC<AssayDomainFormProps> = memo(props => {
         domainFormDisplayOptions,
         firstState,
         headerPrefix,
-        hideAdvancedProperties,
+        appPropertiesOnly,
         index,
         onDomainChange,
         onTogglePanel,
@@ -125,7 +127,7 @@ const AssayDomainForm: FC<AssayDomainFormProps> = memo(props => {
         <DomainForm
             api={api}
             appDomainHeaderRenderer={appDomainHeaderRenderer}
-            appPropertiesOnly={hideAdvancedProperties}
+            appPropertiesOnly={appPropertiesOnly}
             controlledCollapse
             domain={domain}
             domainFormDisplayOptions={displayOptions}
@@ -450,6 +452,7 @@ export class AssayDesignerPanelsImpl extends React.PureComponent<Props, State> {
                             <AssayDomainForm
                                 api={api}
                                 appDomainHeaders={appDomainHeaders}
+                                appPropertiesOnly={appPropertiesOnly}
                                 currentPanelIndex={currentPanelIndex}
                                 domain={domain}
                                 domainFormDisplayOptions={domainFormDisplayOptions}

packages/components/src/internal/components/domainproperties/assay/AssayDesignerPanels.tsx

@@ -2248,6 +2248,7 @@ export interface IDomainFormDisplayOptions {
     isDragDisabled?: boolean;
     phiLevelDisabled?: boolean;
     retainReservedFields?: boolean;
+    showAdvancedSettingsForApp?: boolean;
     showFilterCriteria?: boolean;
     showScannableOption?: boolean;
     textChoiceLockedForDomain?: boolean;

packages/components/src/internal/components/domainproperties/models.tsx

@@ -129,8 +129,10 @@ export function formatSavedResults(
 
     const { key, orderedModels } = result;
     const models = fromJS(result.models[key]);
-    const orderedResults = orderedModels[key]
-        .reduce((ordered, k) => ordered.set(k, models.get(k)), OrderedMap<string, any>());
+    const orderedResults = orderedModels[key].reduce(
+        (ordered, k) => ordered.set(k, models.get(k)),
+        OrderedMap<string, any>()
+    );
 
     return formatResults(model, orderedResults, token);
 }