DataClass Update Pages (#1806)

* Remove SOURCE_TYPE_KEY

Author: labkey-alan

packages/components/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/components",
-  "version": "6.48.1",
+  "version": "6.49.0",
   "description": "Components, models, actions, and utility functions for LabKey applications and pages",
   "sideEffects": false,
   "files": [

packages/components/package.json

@@ -1,6 +1,10 @@
 # @labkey/components
 Components, models, actions, and utility functions for LabKey applications and pages
 
+### version 6.49.0
+*Released*: 11 June 2025
+- Remove SOURCE_TYPE_KEY constant
+
 ### version 6.48.1
 *Released*: 10 June 2025
 - Update `AppLink` to extend all props of `AnchorHTMLAttributes`

packages/components/releaseNotes/components.md

@@ -855,7 +855,6 @@ import {
     SAMPLES_KEY,
     SEARCH_KEY,
     SERVER_NOTIFICATION_MAX_ROWS,
-    SOURCE_TYPE_KEY,
     SOURCES_KEY,
     TEAM_KEY,
     TEAM_PICKLISTS_HREF,
@@ -1044,7 +1043,6 @@ const App = {
     SEARCH_KEY,
     DATA_CLASS_KEY,
     SOURCES_KEY,
-    SOURCE_TYPE_KEY,
     WORKFLOW_KEY,
     FREEZERS_KEY,
     BOXES_KEY,

packages/components/src/index.ts

@@ -38,7 +38,6 @@ export const SAMPLE_TYPE_KEY = 'sampleType';
 export const SEARCH_KEY = 'search';
 export const SOURCES_KEY = 'sources';
 export const DATA_CLASS_KEY = 'dataclass';
-export const SOURCE_TYPE_KEY = 'sourceType';
 export const WORKFLOW_KEY = 'workflow';
 export const FREEZERS_KEY = 'freezers';
 export const ITEMS_KEY = 'items';
@@ -79,7 +78,7 @@ export const FILE_UPDATE_SAMPLES_HREF = AppURL.create(SAMPLES_KEY, 'new').addPar
     'mode',
     EntityCreationMode.FILE_UPDATE
 );
-export const NEW_SOURCE_TYPE_HREF = AppURL.create(SOURCE_TYPE_KEY, 'new');
+export const NEW_SOURCE_TYPE_HREF = AppURL.create(SOURCES_KEY, 'new');
 export const NEW_SAMPLE_TYPE_HREF = AppURL.create(SAMPLE_TYPE_KEY, 'new');
 export const NEW_STANDARD_ASSAY_DESIGN_HREF = AppURL.create(ASSAY_DESIGN_KEY, GENERAL_ASSAY_PROVIDER_NAME);
 export const NEW_ASSAY_DESIGN_HREF = AppURL.create(ASSAY_DESIGN_KEY, 'new');

packages/components/src/internal/app/constants.ts

@@ -1222,7 +1222,7 @@ describe('addSourcesSectionConfig', () => {
         expect(sectionConfig.headerURLPart).toBe(undefined);
         expect(sectionConfig.headerText).toBe(undefined);
         if (canDesign) {
-            expect(sectionConfig.emptyAppURL?.toHref()).toContain('#/sourceType/new');
+            expect(sectionConfig.emptyAppURL?.toHref()).toContain('#/sources/new');
             expect(sectionConfig.emptyURLText).toBe('Create a source type');
         } else {
             expect(sectionConfig.emptyAppURL).toBe(undefined);

packages/components/src/internal/app/utils.test.ts

@@ -13,8 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { Map } from 'immutable';
-
 import { getSelectedDataDeprecated } from '../../actions';
 
 import { QueryModel } from '../../../public/QueryModel/QueryModel';
@@ -64,9 +62,6 @@ export class EditableGridLoaderFromSelection implements EditableGridLoader {
     async fetch(): Promise<GridResponse> {
         const { queryName, queryParameters, schemaName, sortString, viewName } = this.queryModel;
         const selectedIds = this.queryModel.getSelectedIds(this.idsNotPermitted);
-        // TODO: when going form Bulk Update -> Edit in Grid this getSelectedData call is redundant, as our
-        //  BulkUpdateForm gives us the selected data. In a future PR we'll update this loader to optionally accept the
-        //  already existing selection data. See SamplesEditableGrid for an example that is passed selectionData.
         const { data, dataIds } = await getSelectedDataDeprecated(
             schemaName,
             queryName,

packages/components/src/internal/components/editable/EditableGridLoaderFromSelection.tsx

@@ -45,7 +45,6 @@ import {
     ASSAYS_KEY,
     PICKLIST_KEY,
     ELN_KEY,
-    SOURCE_TYPE_KEY,
     SOURCES_KEY,
     FREEZERS_KEY,
     BOXES_KEY,
@@ -358,7 +357,6 @@ const HEADER_MENU_SUBTITLE_MAP = {
     [REGISTRY_KEY]: 'Registry Sources',
     [SAMPLE_TYPE_KEY.toLowerCase()]: 'Sample Types',
     [SAMPLES_KEY]: 'Sample Types',
-    [SOURCE_TYPE_KEY.toLowerCase()]: 'Source Types',
     [SOURCES_KEY]: 'Source Types',
     [SEARCH_KEY]: 'Search',
     [WORKFLOW_KEY]: 'Workflow',