Skip to content

Commit 5eab9c9

Browse files
authored
Add/update links for the GitHub issues in /kanban/issues (#1894)
* remap kanban issue number to internal-issues number
1 parent 42cd2fa commit 5eab9c9

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/components/src/internal/components/domainproperties/AdvancedSettings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ export class AdvancedSettings extends React.PureComponent<AdvancedSettingsProps,
243243
showDefaultValues = () => {
244244
const { field, showDefaultValueSettings } = this.props;
245245

246-
// GitHub Issue #783: we don't yet support default values in the App
246+
// GitHub Issue #298: we don't yet support default values in the App
247247
if (isApp()) return false;
248248

249249
// some domains just don't support default values

packages/components/src/internal/components/domainproperties/models.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1458,7 +1458,7 @@ describe('resolveBaseProperties', () => {
14581458
expect(field.rangeURI).toBe(SAMPLE_TYPE.rangeURI);
14591459
expect(field.required).toBe(true);
14601460

1461-
// GitHub Issue 787
1461+
// GitHub Issue #656
14621462
field = DomainField.resolveBaseProperties({ name: 'SampleId', required: false });
14631463
expect(field.dataType).toBe(SAMPLE_TYPE);
14641464
expect(field.conceptURI).toBe(SAMPLE_TYPE.conceptURI);

packages/components/src/internal/components/domainproperties/models.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1181,7 +1181,7 @@ export class DomainField
11811181
field.dataType = SAMPLE_TYPE;
11821182
field.conceptURI = SAMPLE_TYPE.conceptURI;
11831183
field.rangeURI = SAMPLE_TYPE.rangeURI;
1184-
field.required = !!(raw.required ?? true); // GitHub Issue 787
1184+
field.required = !!(raw.required ?? true); // GitHub Issue #656
11851185
}
11861186
}
11871187

packages/components/src/internal/components/samples/actions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ export function createSessionAssayRunSummaryQuery(sampleIds: number[]): Promise<
378378
assayRunsQuery = 'AssayRunsPerSampleChildFolder';
379379
}
380380

381-
// GitHub Issue 748: need to account for the case with no sampleIds
381+
// GitHub Issue #643: need to account for the case with no sampleIds
382382
let whereClause = 'WHERE RowId IN (' + sampleIds.join(',') + ')\n';
383383
if (sampleIds.length === 0) {
384384
whereClause = 'WHERE 1 = 0\n'; // add where clause that will always result in zero rows

0 commit comments

Comments
 (0)