Add tests

Author: labkey-nicka

packages/components/src/internal/components/files/FileAttachmentContainer.test.tsx

@@ -16,7 +16,12 @@
 import React from 'react';
 import { render } from '@testing-library/react';
 
-import { FileAttachmentContainer } from './FileAttachmentContainer';
+import {
+    FileAttachmentContainer,
+    getTransferItemDirectoryEntry,
+    isDirectoryEntry,
+    isFileEntry,
+} from './FileAttachmentContainer';
 
 describe('FileAttachmentContainer', () => {
     test('with single file', () => {
@@ -29,7 +34,7 @@ describe('FileAttachmentContainer', () => {
         );
 
         expect(document.querySelector('.file-upload__container').className).toContain('hidden');
-        expect(document.querySelector('.attached-file__container').textContent).toBe('file1.txt');
+        expect(document.querySelector('.attached-file__container')).toHaveTextContent('file1.txt');
     });
 
     test('with multiple files', () => {
@@ -46,8 +51,8 @@ describe('FileAttachmentContainer', () => {
 
         expect(document.querySelector('.file-upload__container').className).toContain('block');
         expect(document.querySelectorAll('.attached-file__container')).toHaveLength(2);
-        expect(document.querySelectorAll('.attached-file__container')[0].textContent).toBe('file1.txt');
-        expect(document.querySelectorAll('.attached-file__container')[1].textContent).toBe('file2.txt');
+        expect(document.querySelectorAll('.attached-file__container')[0]).toHaveTextContent('file1.txt');
+        expect(document.querySelectorAll('.attached-file__container')[1]).toHaveTextContent('file2.txt');
 
         expect(document.querySelectorAll('.file-upload__file-entry-listing')).toHaveLength(1);
         expect(document.querySelectorAll('.file-upload__scroll-footer')).toHaveLength(0);
@@ -91,7 +96,7 @@ describe('FileAttachmentContainer', () => {
         expect(document.querySelector('.file-upload__container').className).toContain('block');
         expect(document.querySelectorAll('.attached-file__container')).toHaveLength(2);
         expect(document.querySelectorAll('.file-upload__file-entry-listing')).toHaveLength(1);
-        expect(document.querySelector('.file-upload__scroll-footer').textContent).toBe('2 files will be uploaded.');
+        expect(document.querySelector('.file-upload__scroll-footer')).toHaveTextContent('2 files will be uploaded.');
     });
 
     test('fileCountSuffix with single', () => {
@@ -109,6 +114,92 @@ describe('FileAttachmentContainer', () => {
         expect(document.querySelector('.file-upload__container').className).toContain('block');
         expect(document.querySelectorAll('.attached-file__container')).toHaveLength(1);
         expect(document.querySelectorAll('.file-upload__file-entry-listing')).toHaveLength(1);
-        expect(document.querySelector('.file-upload__scroll-footer').textContent).toBe('1 file will be uploaded.');
+        expect(document.querySelector('.file-upload__scroll-footer')).toHaveTextContent('1 file will be uploaded.');
+    });
+});
+
+describe('File System Helper Functions', () => {
+    function mockFileSystemEntry(isDirectory: boolean, isFile: boolean): FileSystemEntry {
+        return {
+            filesystem: undefined,
+            fullPath: undefined,
+            isDirectory,
+            isFile,
+            name: undefined,
+            getParent: jest.fn(),
+        };
+    }
+
+    function mockDataTransferItemList(entry: FileSystemEntry): DataTransferItemList {
+        return {
+            0: {
+                webkitGetAsEntry: jest.fn().mockReturnValue(entry),
+            },
+        } as unknown as DataTransferItemList;
+    }
+
+    describe('isDirectoryEntry', () => {
+        it('should return true when entry is a directory', () => {
+            const mockDirEntry = mockFileSystemEntry(true, false);
+            expect(isDirectoryEntry(mockDirEntry)).toBe(true);
+        });
+
+        it('should return false when entry is a file', () => {
+            const mockFileEntry = mockFileSystemEntry(false, true);
+            expect(isDirectoryEntry(mockFileEntry)).toBe(false);
+        });
+
+        it('should return false when entry is undefined', () => {
+            expect(isDirectoryEntry(undefined)).toBe(false);
+            expect(isDirectoryEntry(null)).toBe(false);
+            expect(isDirectoryEntry({} as unknown as FileSystemEntry)).toBe(false);
+        });
+    });
+
+    describe('isFileEntry', () => {
+        it('should return true when entry is a file', () => {
+            const mockFileEntry = mockFileSystemEntry(false, true);
+            expect(isFileEntry(mockFileEntry)).toBe(true);
+        });
+
+        it('should return false when entry is a directory', () => {
+            const mockDirEntry = mockFileSystemEntry(true, false);
+            expect(isFileEntry(mockDirEntry)).toBe(false);
+        });
+
+        it('should return false when entry is undefined', () => {
+            expect(isFileEntry(undefined)).toBe(false);
+            expect(isFileEntry(null)).toBe(false);
+            expect(isFileEntry({} as unknown as FileSystemEntry)).toBe(false);
+        });
+    });
+
+    describe('getTransferItemDirectoryEntry', () => {
+        it('should return directory entry when item at index is a directory', () => {
+            const mockDirEntry = mockFileSystemEntry(true, false);
+            const mockTransferItems = mockDataTransferItemList(mockDirEntry);
+
+            const result = getTransferItemDirectoryEntry(mockTransferItems, 0);
+            expect(result).toBe(mockDirEntry);
+            expect(mockTransferItems[0].webkitGetAsEntry).toHaveBeenCalledTimes(1);
+        });
+
+        it('should return undefined when item at index is a file', () => {
+            const mockFileEntry = mockFileSystemEntry(false, true);
+            const mockTransferItems = mockDataTransferItemList(mockFileEntry);
+
+            const result = getTransferItemDirectoryEntry(mockTransferItems, 0);
+            expect(result).toBeUndefined();
+        });
+
+        it('should return undefined when index is out of bounds', () => {
+            expect(getTransferItemDirectoryEntry(undefined as DataTransferItemList, 0)).toBeUndefined();
+            expect(getTransferItemDirectoryEntry({} as DataTransferItemList, 999)).toBeUndefined();
+        });
+
+        it('should return undefined when webkitGetAsEntry returns null', () => {
+            const mockTransferItems = mockDataTransferItemList(null);
+            expect(getTransferItemDirectoryEntry(mockTransferItems, 0)).toBeUndefined();
+        });
     });
 });

packages/components/src/internal/components/files/FileAttachmentContainer.tsx

@@ -29,13 +29,13 @@ import { fileMatchesAcceptedFormat, fileSizeLimitCompare } from './actions';
 import { FileAttachmentEntry } from './FileAttachmentEntry';
 import { ALL_FILES_LIMIT_KEY } from './models';
 
-const isDirectoryEntry = (entry: FileSystemEntry): entry is FileSystemDirectoryEntry => !!entry?.isDirectory;
-const isFileEntry = (entry: FileSystemEntry): entry is FileSystemFileEntry => !!entry?.isFile;
+export const isDirectoryEntry = (entry: FileSystemEntry): entry is FileSystemDirectoryEntry => !!entry?.isDirectory;
+export const isFileEntry = (entry: FileSystemEntry): entry is FileSystemFileEntry => !!entry?.isFile;
 export const getTransferItemDirectoryEntry = (
     transferItems: DataTransferItemList,
     index: number
 ): FileSystemDirectoryEntry | undefined => {
-    const entry = transferItems?.[index]?.webkitGetAsEntry();
+    const entry = transferItems?.[index]?.webkitGetAsEntry?.();
     if (entry && isDirectoryEntry(entry)) return entry;
     return undefined;
 };