code review changes

Author: XingY

packages/components/package-lock.json

@@ -267,6 +267,7 @@ export function exportRows(type: EXPORT_TYPES, exportParams: Record<string, any>
     Object.keys(exportParams).forEach(key => {
         const value = exportParams[key];
 
+        // Issue 52925: App export to csv/tsv ignores filter with column containing double quote
         if (value instanceof Array) {
             value.forEach(arrayValue => form.append(encodeFormDataQuote(key), arrayValue));
         } else {

packages/components/src/internal/actions.ts

@@ -0,0 +1,26 @@
+import { encodeFormDataQuote } from './utils';
+
+describe('encodeFormDataQuote', () => {
+    test('empty', () => {
+        expect(encodeFormDataQuote(null)).toBeNull();
+        expect(encodeFormDataQuote(undefined)).toBeUndefined();
+        expect(encodeFormDataQuote('')).toBe('');
+    });
+
+    test('no relevant special character', () => {
+        expect(encodeFormDataQuote('a')).toBe('a')
+        expect(encodeFormDataQuote('$')).toBe('$');
+        expect(encodeFormDataQuote('%')).toBe('%');
+        expect(encodeFormDataQuote('%2522')).toBe('%2522');
+    });
+
+    test('encoded', () => {
+        expect(encodeFormDataQuote('"')).toBe('%22')
+        expect(encodeFormDataQuote('""')).toBe('%22%22');
+        expect(encodeFormDataQuote('"22')).toBe('%2222');
+        expect(encodeFormDataQuote('"a"')).toBe('%22a%22');
+        expect(encodeFormDataQuote('a%22')).toBe('a%2522');
+        expect(encodeFormDataQuote('"a%22')).toBe('%22a%2522');
+        expect(encodeFormDataQuote('"a%222')).toBe('%22a%25222');
+    });
+});

packages/components/src/internal/url/utils.test.ts

@@ -7,5 +7,7 @@ export function encodeListResolverPath(containerPath: string): string {
 }
 
 export function encodeFormDataQuote(key: string): string {
+    if (!key)
+        return key;
     return key?.replaceAll('%22', '%2522').replaceAll('"', '%22');
 }