code review changes

Author: XingY

packages/components/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@labkey/components",
-  "version": "6.62.4-fb-issue53036.1",
+  "version": "6.62.4-fb-issue53036.2",
   "description": "Components, models, actions, and utility functions for LabKey applications and pages",
   "sideEffects": false,
   "files": [

packages/components/src/internal/components/auditlog/models.ts

@@ -102,7 +102,7 @@ export class TimelineEventModel extends Record({
     }
 
     // timezoneStr used for jest test only, to accommodate teamcity timezone difference
-    static create(raw: any, timezoneStr?: string, inheritedFields?: string[]): TimelineEventModel {
+    static create(raw: any, timezoneStr?: string, inheritedFieldKeys?: string[]): TimelineEventModel {
         const fields = {} as TimelineEventModel;
         fields.rowId = raw['rowId'];
         fields.eventType = raw['eventType'];
@@ -127,8 +127,8 @@ export class TimelineEventModel extends Record({
             fields.metadata = fromJS(metaRows);
         }
 
-        if (raw.oldData) fields.oldData = getAuditDetailMap(raw.oldData, inheritedFields);
-        if (raw.newData) fields.newData = getAuditDetailMap(raw.newData, inheritedFields);
+        if (raw.oldData) fields.oldData = getAuditDetailMap(raw.oldData, inheritedFieldKeys);
+        if (raw.newData) fields.newData = getAuditDetailMap(raw.newData, inheritedFieldKeys);
         if (raw.providedValues) fields.providedValues = raw.providedValues;
         if (raw.providedDeltaValues) fields.providedDeltaValues = raw.providedDeltaValues;
 

packages/components/src/internal/components/auditlog/utils.ts

@@ -149,11 +149,11 @@ export function getTimelineEntityUrl(d: Record<string, any>): AppURL {
 
 export function getAuditDetailMap(
     data: Record<string, string>,
-    inheritedFields?: string[]
+    inheritedFieldKeys?: string[]
 ): OrderedMap<string, string> {
-    if (inheritedFields?.length > 0) {
+    if (inheritedFieldKeys?.length > 0) {
         // sort fields.newData so that inherited fields are at the bottom
-        const inheritedFieldsLc = inheritedFields.map(f => f.toLowerCase());
+        const inheritedFieldsLc = inheritedFieldKeys.map(f => f.toLowerCase());
         const newData = data ?? {};
         const sortedNewData = {} as any;
         const last = {};