Skip to content

Commit cee5a9f

Browse files
committed
merge from develop
2 parents 4501b45 + e7fc128 commit cee5a9f

6 files changed

Lines changed: 12 additions & 8 deletions

File tree

packages/components/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@labkey/components",
3-
"version": "6.65.2-showSelectedValue-52310.2",
3+
"version": "6.65.3-showSelectedValue-52310.2",
44
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
55
"sideEffects": false,
66
"files": [

packages/components/releaseNotes/components.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ Components, models, actions, and utility functions for LabKey applications and p
55
*Released* TBD
66
- Issue 52310: Change application single-value dropdowns to include the current value in the listed options
77

8+
### version TBD
9+
*Released*: TBD
10+
- Various minor fixes for exception reports
11+
812
### version 6.65.1
913
*Released*: 20 October 2025
1014
- SelectionStatus null check for rowCount

packages/components/src/internal/Modal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ export const BaseModal: FC<BaseModalProps> = ({ bsSize, children, className }) =
2525

2626
useEffect(() => {
2727
// Prevent scrolling the body when a modal is shown
28-
document.body.classList.toggle('no-scroll', true);
28+
document.body.classList?.toggle('no-scroll', true);
2929
return () => {
30-
document.body.classList.toggle('no-scroll', false);
30+
document.body.classList?.toggle('no-scroll', false);
3131
};
3232
}, []);
3333

packages/components/src/internal/components/base/models/User.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export function checkPermissions(
142142
* @param perms Array of permission strings (See models/constants)
143143
* @param checkIsAdmin Indicates if user.isAdmin should override check. Defaults to true.
144144
* @param permissionCheck Sets which "has permissions" check logic is used.
145-
* `all` - Require user to have all of the specified permissions (default).
145+
* `all` - Require user to have all the specified permissions (default).
146146
* `any` - Require user to have any of the specified permissions.
147147
*/
148148
export function hasPermissions(
@@ -151,7 +151,7 @@ export function hasPermissions(
151151
checkIsAdmin = true,
152152
permissionCheck: 'all' | 'any' = 'all'
153153
): boolean {
154-
return checkPermissions(user.isAdmin, user.permissionsList, perms, checkIsAdmin, permissionCheck);
154+
return checkPermissions(user?.isAdmin, user?.permissionsList, perms, checkIsAdmin, permissionCheck);
155155
}
156156

157157
/**

packages/components/src/public/QueryModel/QueryModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -779,7 +779,7 @@ export class QueryModel {
779779
}
780780

781781
let sortStrings = sorts.map(sortStringMapper);
782-
const viewSorts = queryInfo.getSorts(viewName).map(sortStringMapper);
782+
const viewSorts = queryInfo.getSorts(viewName)?.map(sortStringMapper) ?? [];
783783

784784
if (viewSorts.length > 0) {
785785
sortStrings = sortStrings.concat(viewSorts);

0 commit comments

Comments
 (0)