CR feedback

labkey-martyp · labkey-martyp · commit 7f7561e31573 · 2026-02-13T07:20:03.000-08:00
diff --git a/nirc_ehr/resources/queries/study/arrival.js b/nirc_ehr/resources/queries/study/arrival.js
@@ -4,7 +4,6 @@ var triggerHelper = new org.labkey.nirc_ehr.query.NIRC_EHRTriggerHelper(LABKEY.S
 
 EHR.Server.TriggerManager.registerHandlerForQuery(EHR.Server.TriggerManager.Events.BEFORE_UPSERT, 'study', 'Arrival', function(helper, scriptErrors, row, oldRow) {
 
-    console.log('isRearrival:', row.rearrival);
     if(!row.rearrival){
         helper.setScriptOptions({requiresStatusRecalc: true});
     }
diff --git a/nirc_ehr/src/org/labkey/nirc_ehr/dataentry/form/NIRCRearrivalFormType.java b/nirc_ehr/src/org/labkey/nirc_ehr/dataentry/form/NIRCRearrivalFormType.java
@@ -27,12 +27,10 @@ public NIRCRearrivalFormType(DataEntryFormContext ctx, Module owner)
                 new NIRCRearrivalFormSection()
         ));
 
-        addClientDependency(ClientDependency.supplierFromPath("nirc_ehr/model/sources/Arrival.js"));
         addClientDependency(ClientDependency.supplierFromPath("nirc_ehr/model/sources/Rearrival.js"));
 
         for (FormSection s : getFormSections())
         {
-            s.addConfigSource("Arrival");
             s.addConfigSource("Rearrival");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@ var triggerHelper = new org.labkey.nirc_ehr.query.NIRC_EHRTriggerHelper(LABKEY.S`
`4`	`4`
`5`	`5`	`EHR.Server.TriggerManager.registerHandlerForQuery(EHR.Server.TriggerManager.Events.BEFORE_UPSERT, 'study', 'Arrival', function(helper, scriptErrors, row, oldRow) {`
`6`	`6`
`7`		`- console.log('isRearrival:', row.rearrival);`
`8`	`7`	`if(!row.rearrival){`
`9`	`8`	`helper.setScriptOptions({requiresStatusRecalc: true});`
`10`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,12 +27,10 @@ public NIRCRearrivalFormType(DataEntryFormContext ctx, Module owner)`
`27`	`27`	`new NIRCRearrivalFormSection()`
`28`	`28`	`));`
`29`	`29`
`30`		`- addClientDependency(ClientDependency.supplierFromPath("nirc_ehr/model/sources/Arrival.js"));`
`31`	`30`	`addClientDependency(ClientDependency.supplierFromPath("nirc_ehr/model/sources/Rearrival.js"));`
`32`	`31`
`33`	`32`	`for (FormSection s : getFormSections())`
`34`	`33`	`{`
`35`		`- s.addConfigSource("Arrival");`
`36`	`34`	`s.addConfigSource("Rearrival");`
`37`	`35`	`}`
`38`	`36`	`}`