Commit 4dd5cac
authored
Improve accessibility - remove inappropriate role="presentation" on tabs (#7534)
#### Rationale
We are inappropriately tagging our folder portal tabs with
`role="presentation"`. You're not allowed to use it on an `<li>` without
a similar tag on a parent element like the `<ul>`.
Since these tabs are full-page navigations instead of in-page
replacements, it seems the most appropriate thing is to simply remove
this incorrect attribute.
https://www.w3.org/WAI/ARIA/apg/practices/hiding-semantics/
#### Changes
- Remove `role="presentation"` from folder portal tabs
- Signify the active tab using `aria-current="page"`
<!-- list of standard tasks (remove this comment to enable)
#### Tasks 📍
- [ ] Manual Testing
- [ ] Needs Automation
- [ ] Verify Fix
-->1 parent 49c3073 commit 4dd5cac
1 file changed
Lines changed: 5 additions & 5 deletions
File tree
- core/src/org/labkey/core/view/template/bootstrap
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
118 | | - | |
| 117 | + | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
| 163 | + | |
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
| 184 | + | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| |||
0 commit comments