Clear exception count and warnings after encrypted content is cleared (#7538)

Author: labkey-adam

api/src/org/labkey/api/security/Encryption.java

@@ -672,6 +672,9 @@ public static void deleteEncryptedContent(User user)
         event.setChanges(changes);
         AuditLogService.get().addEvent(user, event);
         CacheManager.clearAllKnownCaches();
+        // Reset the counter and clear the warnings
+        DECRYPTION_EXCEPTIONS.set(0);
+        WarningService.get().clearStaticWarnings();
         LOG.info("Finished deleting all encrypted content");
     }
 

api/src/org/labkey/api/view/template/WarningService.java

@@ -42,4 +42,5 @@ static void setInstance(WarningService impl)
     Warnings getWarnings(@Nullable ViewContext context);
     HtmlString getWarningsHtml(Warnings warnings, ViewContext context);
     void rerunSchemaCheck(); // Doesn't really fit on this service, but there's no better existing service
+    void clearStaticWarnings();
 }

core/src/org/labkey/core/admin/AdminController.java

@@ -3688,7 +3688,7 @@ public AttachmentsForTypeAction()
         public void addNavTrail(NavTree root)
         {
             String parentType = getViewContext().getActionURL().getParameter("core.ParentType~eq");
-            addAdminNavTrail(root, "Documents Belonging to Parent Type" + (parentType != null ? " \"" + parentType + "\"" : ""), getClass());
+            addAdminNavTrail(root, parentType != null ? "Documents Belonging to Parent Type \"" + parentType + "\"" : "Documents", getClass());
         }
     }
 

core/src/org/labkey/core/view/template/bootstrap/WarningServiceImpl.java

@@ -61,7 +61,7 @@ private static class LazyInitializer
                 SHOW_ALL_WARNINGS = OptionalFeatureService.get().isFeatureEnabled(EXPERIMENTAL_SHOW_ALL_WARNINGS);
                 OptionalFeatureService.get().addFeatureListener(EXPERIMENTAL_SHOW_ALL_WARNINGS, (feature, enabled) -> {
                     SHOW_ALL_WARNINGS = enabled;
-                    clearStaticWarnings(); // Force static warnings to be re-collected since flag has changed
+                    WarningService.get().clearStaticWarnings(); // Force static warnings to be re-collected since flag has changed
                 });
             }
         }
@@ -86,7 +86,8 @@ public void register(WarningProvider provider)
         clearStaticWarnings();
     }
 
-    private static void clearStaticWarnings()
+    @Override
+    public void clearStaticWarnings()
     {
         synchronized (STATIC_WARNING_LOCK)
         {
@@ -194,7 +195,7 @@ private void appendMessageContent(Warnings warnings, HtmlStringBuilder html)
             List<HtmlString> messages = warnings.getMessages();
 
             if (messages.size() == 1)
-                html.append(messages.get(0));
+                html.append(messages.getFirst());
             else
             {
                 html.startTag("ul");