Switch to throw an exception

labkey-adam · labkey-adam · commit 843e7ffe1014 · 2026-03-28T22:08:06.000-07:00
diff --git a/api/src/org/labkey/api/settings/OptionalFeatureFlag.java b/api/src/org/labkey/api/settings/OptionalFeatureFlag.java
@@ -44,9 +44,7 @@ public OptionalFeatureFlag(String flag, String title, String description, boolea
             }
             else
             {
-                // TODO: Switch to throw IllegalStateException
-                LOG.error(_flag + " is not a valid Java identifier. Correct it so it can be used as a startup property. Or set useDumbName to true.", new IllegalStateException());
-                _propertyName = null;
+                throw new IllegalStateException(_flag + " is not a valid Java identifier. Correct it so it can be used as a startup property. Or set useDumbName to true.");
             }
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,7 @@ public OptionalFeatureFlag(String flag, String title, String description, boolea`
`44`	`44`	`}`
`45`	`45`	`else`
`46`	`46`	`{`
`47`		`- // TODO: Switch to throw IllegalStateException`
`48`		`- LOG.error(_flag + " is not a valid Java identifier. Correct it so it can be used as a startup property. Or set useDumbName to true.", new IllegalStateException());`
`49`		`- _propertyName = null;`
	`47`	`+ throw new IllegalStateException(_flag + " is not a valid Java identifier. Correct it so it can be used as a startup property. Or set useDumbName to true.");`
`50`	`48`	`}`
`51`	`49`	`}`
`52`	`50`	`else`