Skip to content

Commit ee7789c

Browse files
authored
Fb snd events viewer (#286)
* New dev - SndEventsViewer * Router refactor * Tweaked GridPanel and moved page behind admin wall * @labkey/components update broke jest tests 1. updated @labkey/api 2. added local LoadingSpinner.jsx component and style 3. updated tests and snapshots
1 parent 5559b23 commit ee7789c

30 files changed

Lines changed: 827 additions & 354 deletions

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ snprc_ehr/resources/views/helloWorld*.*
1717
snprc_ehr/resources/views/NewAnimalPage*.*
1818
snprc_ehr/resources/views/BirthRecordReport*.*
1919
snprc_ehr/resources/views/ChipReader*.*
20+
snprc_ehr/resources/views/SndEventsViewer*.*
2021
snprc_ehr/cmd-here.exe
2122
snprc_ehr/resources/referenceStudy/*.xlsx
2223
snprc_ehr/resources/web/snprc_ehr/snprcReports.js.gz

snprc_ehr/package-lock.json

Lines changed: 273 additions & 324 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

snprc_ehr/package.json

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,18 @@
4646
},
4747
"dependencies": {
4848
"@babel/runtime": "^7.10.2",
49-
"@labkey/api": "0.0.45",
50-
"@labkey/components": "^0.56.3",
51-
"@types/react": "16.8.19",
52-
"@types/react-bootstrap": "0.32.21",
53-
"@types/react-dom": "16.8.4",
49+
"@labkey/api": "^1.1.0",
50+
"@labkey/components": "^0.89.0",
5451
"immutable": "3.8.2",
5552
"moment": "^2.26.0",
56-
"react": "16.8.6",
53+
"react": "^16.13.1",
5754
"react-bootstrap-table": "^4.3.1",
5855
"react-data-grid": "^7.0.0-canary.16",
5956
"react-data-grid-addons": "^7.0.0-alpha.24",
6057
"react-datepicker": "^2.16.0",
61-
"react-dom": "16.8.6",
58+
"react-dom": "^16.13.1",
6259
"react-moment": "^0.9.7",
60+
"react-router": "^3.2.6",
6361
"react-select": "^3.1.0",
6462
"styled-components": "^5.1.1"
6563
},
@@ -74,8 +72,12 @@
7472
"@hot-loader/react-dom": "16.9.0",
7573
"@types/enzyme": "3.10.5",
7674
"@types/jest": "^25.2.3",
75+
"@types/react": "^16.9.44",
76+
"@types/react-bootstrap": "^0.32.22",
7777
"@types/react-datepicker": "^2.11.1",
78+
"@types/react-dom": "^16.9.8",
7879
"@types/react-hot-loader": "4.1.0",
80+
"@types/react-router": "^3.0.23",
7981
"babel-eslint": "^10.1.0",
8082
"babel-jest": "^26.0.1",
8183
"babel-loader": "8.0.6",
@@ -104,11 +106,12 @@
104106
"node-sass": "4.12.0",
105107
"postcss-loader": "3.0.0",
106108
"prettier": "^2.0.5",
107-
"react-bootstrap": "0.33.1",
109+
"react-bootstrap": "^0.33.1",
108110
"react-hot-loader": "4.8.8",
109111
"react-test-renderer": "16.9.0",
110112
"resolve-url-loader": "3.1.0",
111113
"sass-loader": "7.1.0",
114+
"source-map-loader": "^1.0.2",
112115
"style-loader": "1.0.0",
113116
"ts-jest": "^26.1.0",
114117
"ts-loader": "6.0.2",

snprc_ehr/resources/views/begin.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@
168168
{ name: 'EHR Admin Page', url: '<%=contextPath%>/snprc_ehr' + ctx['EHRStudyContainer'] + '/ehrAdmin.view' },
169169
{ name: 'Manage EHR Study', url: '<%=contextPath%>/study' + ctx['EHRStudyContainer'] + '/manageStudy.view?' },
170170
{ name: 'Manage Lookup Tables', url: '<%=contextPath%>/snprc_ehr' + ctx['EHRStudyContainer'] + '/editLookupTables.view' },
171-
{ name: 'Enter Data', url: '<%=contextPath%>/ehr' + ctx['EHRStudyContainer'] + '/dataEntry.view' }
171+
{ name: 'Enter Data', url: '<%=contextPath%>/ehr' + ctx['EHRStudyContainer'] + '/dataEntry.view' },
172+
{ name: 'SND Events Viewer',url: '<%=contextPath%>/snprc_ehr' + ctx['EHRStudyContainer'] + '/SndEventView.view?'}
172173
]
173174
});
174175
}

snprc_ehr/src/client/BirthRecordReport/BirthRecordReport.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* eslint-disable no-alert */
22

33
import React from 'react'
4-
import { LoadingSpinner } from '@labkey/components'
4+
import { LoadingSpinner } from '../Shared/components/LoadingSpinner'
55
import './styles/birthRecordReport.scss'
66
import { Button } from 'react-bootstrap'
77
import BirthRecordState from './constants/BirthRecordState'

snprc_ehr/src/client/BirthRecordReport/styles/birthRecordReport.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
@import "../../Shared/styles/components/shared";
55
@import "../../Shared/styles/components/infoPanel";
66
@import "../../Shared/styles/components/summaryGridPanel";
7+
@import "../../Shared/styles/components/loadingSpinner";
78

89

910
.right-panel {

snprc_ehr/src/client/BirthRecordReport/tests/BirthRecordReport.test.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ describe('BirthRecordReport tests', () => {
2727
test('Should render a loading spinner before api calls.', () => {
2828
wrapper = shallow(<BirthRecordReport />, { disableLifecycleMethods: true })
2929
expect(wrapper).toMatchSnapshot()
30-
expect(wrapper.find('LoadingSpinner_LoadingSpinner').exists()).toBeTruthy()
30+
expect(wrapper.find('LoadingSpinner').exists()).toBeTruthy()
3131
})
3232

3333
test('Should render AnimalSelectionPanel.', async () => {
3434
await flushPromises()
3535

3636
// spinner should be gone
37-
expect(wrapper.find('LoadingSpinner_LoadingSpinner').exists()).toBeFalsy()
37+
expect(wrapper.find('LoadingSpinner').exists()).toBeFalsy()
3838

3939
// AnimalSelection panels should be present
4040
expect(wrapper.find('AnimalSelectionPanel').exists()).toBeTruthy()

snprc_ehr/src/client/BirthRecordReport/tests/__snapshots__/BirthRecordReport.test.jsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,9 @@ exports[`BirthRecordReport tests Should render AnimalSelectionPanel. 1`] = `
132132
`;
133133

134134
exports[`BirthRecordReport tests Should render a loading spinner before api calls. 1`] = `
135-
<LoadingSpinner_LoadingSpinner
135+
<LoadingSpinner
136136
msg="Loading app..."
137-
wrapperClassName=""
137+
wrapperClassName="loading-spinner"
138138
/>
139139
`;
140140

snprc_ehr/src/client/ChipReader/ChipReader.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* eslint-disable no-alert */
22

33
import React from 'react'
4-
import { LoadingSpinner } from '@labkey/components'
4+
import { LoadingSpinner } from '../Shared/components/LoadingSpinner'
55
import './styles/chipReader.scss'
66
import ChipReaderState from './constants/chipReaderState'
77
import constants from './constants/index'

snprc_ehr/src/client/ChipReader/styles/chipReader.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
@import "../../Shared/styles/components/infoPanel";
33
@import "../../Shared/styles/components/shared";
44
@import "../../Shared/styles/components/summaryGridPanel";
5+
@import "../../Shared/styles/components/loadingSpinner";
56
@import "../../Shared/styles/formatting/panels";
67
@import "../../Shared/styles/formatting/wizard";
78

0 commit comments

Comments
 (0)