Fix empty Pareto plot

labkey-jeckels · labkey-jeckels · commit 6dd9d520bacb · 2025-10-18T07:33:47.000-07:00
diff --git a/webapp/TargetedMS/js/ParetoPlotPanel.js b/webapp/TargetedMS/js/ParetoPlotPanel.js
@@ -39,7 +39,7 @@ Ext4.define('LABKEY.targetedms.ParetoPlotPanel', {
 
         var parsed = JSON.parse(response.responseText);
 
-        if (Object.keys(parsed.sampleFiles).length === 0) {
+        if (!parsed.sampleFiles || Object.keys(parsed.sampleFiles).length === 0) {
             Ext4.get(this.plotDivId).update('<div class="tiledPlotPanel">No sample files loaded yet. Import some via Skyline, AutoQC, or the Data Pipeline tab here in Panorama.</div>');
             return;
         }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ Ext4.define('LABKEY.targetedms.ParetoPlotPanel', {`
`39`	`39`
`40`	`40`	`var parsed = JSON.parse(response.responseText);`
`41`	`41`
`42`		`- if (Object.keys(parsed.sampleFiles).length === 0) {`
	`42`	`+ if (!parsed.sampleFiles \|\| Object.keys(parsed.sampleFiles).length === 0) {`
`43`	`43`	`Ext4.get(this.plotDivId).update('<div class="tiledPlotPanel">No sample files loaded yet. Import some via Skyline, AutoQC, or the Data Pipeline tab here in Panorama.</div>');`
`44`	`44`	`return;`
`45`	`45`	`}`