Apply suggestions from code review

Co-authored-by: Trey Chadick <tchad@labkey.com>

Author: DariaBod

src/org/labkey/test/components/domain/DomainFormPanel.java

@@ -236,17 +236,8 @@ else if (validator instanceof FieldDefinition.TextChoiceValidator textChoiceVali
                         throw new IllegalArgumentException("TextChoice fields cannot have additional validators.");
                     }
                     fieldRow.setTextChoiceValues(textChoiceValidator.getValues());
-                    fieldRow.setAllowMultipleSelections(false);
+                    fieldRow.setAllowMultipleSelections(fieldDefinition.getType() == FieldDefinition.ColumnType.MultiValueTextChoice);
                 }
-                else if (validator instanceof FieldDefinition.MultiValueTextChoiceValidator multiValueTextChoiceValidator)
-                {
-                    // MultiValueTextChoice is a field type; implemented using a special validator. TextChoice field cannot have other validators.
-                    if (validators.size() > 1)
-                    {
-                        throw new IllegalArgumentException("TextChoice fields cannot have additional validators.");
-                    }
-                    fieldRow.setTextChoiceValues(multiValueTextChoiceValidator.getValues());
-                    fieldRow.setAllowMultipleSelections(true);
                 }
                 else
                 {

src/org/labkey/test/components/ui/search/FilterFacetedPanel.java

@@ -64,7 +64,7 @@ public boolean isFiltersPresented()
      * Select a filer by clicking its label. Right now this method relevant only for multi-value text choice.
      * @param operator desired filter value
      */
-    public void selectFilter(Filter.Operator operator)
+    public void selectArrayFilterOperator(Filter.Operator operator)
     {
         elementCache().filterTypeSelects.select(operator.getDisplayValue());
     }
@@ -144,7 +144,7 @@ protected class ElementCache extends Component<?>.ElementCache
     {
         protected final Input filterInput =
                 Input(Locator.id("filter-faceted__typeahead-input"), getDriver()).findWhenNeeded(this);
-        protected final ReactSelect filterTypeSelects =
+        protected final ReactSelect arrayFilterOperatorSelect =
                 new ReactSelect.ReactSelectFinder(getDriver()).index(0).findWhenNeeded(this);
         protected final WebElement checkboxSection =
                 Locator.byClass("labkey-wizard-pills").index(0).refindWhenNeeded(this);

src/org/labkey/test/pages/query/UpdateQueryRowPage.java

@@ -116,14 +116,9 @@ public UpdateQueryRowPage setField(String fieldName, String value)
 
     public UpdateQueryRowPage setField(String fieldName, List<String> values)
     {
-        WebElement field = elementCache().findField(fieldName, true);
-        List<WebElement> options = field.findElements(By.tagName("option"));
-       //unselect all options that selected but shouldn't be selected
-        options.forEach(option ->
-        {
-            if (!values.contains(option.getText()) && option.getAttribute("selected") != null) option.click();
-        });
-        values.forEach(value -> selectOptionByText(field, value));
+        WebElement field = new Select(elementCache().findField(fieldName, true));
+        field.deselectAll();
+        values.forEach(value -> field.selectByVisibleText(value));
         return this;
     }