Skip to content

Commit 5fc8d2b

Browse files
committed
Expand "See Audit Log Events" test
1 parent af4fa5f commit 5fc8d2b

1 file changed

Lines changed: 18 additions & 9 deletions

File tree

src/org/labkey/test/tests/AuditLogTest.java

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@
6464
import static org.junit.Assert.assertFalse;
6565
import static org.junit.Assert.assertTrue;
6666
import static org.junit.Assert.fail;
67+
import static org.labkey.test.util.PasswordUtil.getUsername;
6768
import static org.labkey.test.util.PermissionsHelper.AUTHOR_ROLE;
6869
import static org.labkey.test.util.PermissionsHelper.EDITOR_ROLE;
6970
import static org.labkey.test.util.PermissionsHelper.FOLDER_ADMIN_ROLE;
7071
import static org.labkey.test.util.PermissionsHelper.PROJECT_ADMIN_ROLE;
71-
import static org.labkey.test.util.PasswordUtil.getUsername;
7272

7373
@Category({Daily.class, Hosting.class})
7474
@BaseWebDriverTest.ClassTimeout(minutes = 9)
@@ -378,18 +378,27 @@ protected void canSeeAuditLogTest()
378378
createUserWithPermissions(AUDIT_TEST_USER2, AUDIT_TEST_PROJECT, PROJECT_ADMIN_ROLE);
379379

380380
// signed in as an admin so we should see rows here
381-
verifyAuditQueries(true);
381+
verifyAuditQueries(true, getProjectName());
382382

383383
// signed in as an editor should not show any rows for audit query links
384384
impersonate(AUDIT_TEST_USER);
385-
verifyAuditQueries(false);
385+
verifyAuditQueries(false, getProjectName());
386+
verifyAuditQueries(false, "home");
387+
stopImpersonating();
388+
389+
// grant CanSeeAuditLog role to our audit user in the project and verify we see audit information in this project but not /home
390+
permissionsHelper.addMemberToRole(AUDIT_TEST_USER, "See Audit Log Events", PermissionsHelper.MemberType.user, getProjectName());
391+
impersonate(AUDIT_TEST_USER);
392+
verifyAuditQueries(true, getProjectName());
393+
verifyAuditQueries(false, "home");
386394
stopImpersonating();
395+
permissionsHelper.removeUserRoleAssignment(AUDIT_TEST_USER, "See Audit Log Events", getProjectName());
387396

388-
// now grant CanSeeAuditLog permission to our audit user and verify
389-
// we see audit information
397+
// grant CanSeeAuditLog role to our audit user in the root and verify we see audit information in this project and in /home
390398
permissionsHelper.setSiteRoleUserPermissions(AUDIT_TEST_USER, "See Audit Log Events");
391399
impersonate(AUDIT_TEST_USER);
392-
verifyAuditQueries(true);
400+
verifyAuditQueries(true, getProjectName());
401+
verifyAuditQueries(true, "home");
393402

394403
// cleanup
395404
stopImpersonating();
@@ -535,15 +544,15 @@ protected void verifyListAuditLogQueries(Visibility v)
535544
verifyAuditQueryEvent(this, "List", "Child List", 1, canSeeChild(v));
536545
}
537546

538-
protected void verifyAuditQueries(boolean canSeeAuditLog)
547+
protected void verifyAuditQueries(boolean canSeeAuditLog, String containerPath)
539548
{
540-
ExecuteQueryPage.beginAt(this, getProjectName(), "auditLog", "ContainerAuditEvent");
549+
ExecuteQueryPage.beginAt(this, containerPath, "auditLog", "ContainerAuditEvent");
541550
if (canSeeAuditLog)
542551
verifyAuditQueryEvent(this, COMMENT_COLUMN, AUDIT_TEST_PROJECT + " was created", 1);
543552
else
544553
assertTextPresent("No data to show.");
545554

546-
ExecuteQueryPage.beginAt(this, getProjectName(), "auditLog", "GroupAuditEvent");
555+
ExecuteQueryPage.beginAt(this, containerPath, "auditLog", "GroupAuditEvent");
547556
if (canSeeAuditLog)
548557
verifyAuditQueryEvent(this, COMMENT_COLUMN, "The user " + AUDIT_TEST_USER + " was assigned to the security role Editor.", 1);
549558
else

0 commit comments

Comments
 (0)